Sainan
3 Followers · 0 Following
  • Joined on 2025-02-01
Repositories Projects Packages Public Activity Starred Repositories
Sainan pushed to kuria at OpenWF/SpaceNinjaServer 2025-02-25 18:54:57 -08:00
87e2391629 handle CollectibleScans in missionInventoryUpdate
Sainan pushed to kuria at OpenWF/SpaceNinjaServer 2025-02-25 18:54:26 -08:00
539d6c7fb2 handle CollectibleScans in missionInventoryUpdate
888dcb7a42 feat: startCollectibleEntry
Compare 2 commits »
Sainan created branch kuria in OpenWF/SpaceNinjaServer 2025-02-25 18:54:26 -08:00
Sainan commented on issue OpenWF/SpaceNinjaServer#712 2025-02-25 18:18:42 -08:00
Duviri/Kuva lore collectibles aren't saved

Scanning a Kuria during a mission:

2025-02-26T03:09:08:222 [0.1.0] error:  unknown endpoint POST /api/startCollectibleEntry.php
2025-02-26T03:09:08:222 [0.1.0] debug:  data provided to…
Sainan pushed to song-challenge at OpenWF/SpaceNinjaServer 2025-02-25 17:57:46 -08:00
ef6acfff18 prettier
Sainan created pull request OpenWF/SpaceNinjaServer#1024 2025-02-25 17:55:13 -08:00
feat: updateSongChallenge
Sainan created branch song-challenge in OpenWF/SpaceNinjaServer 2025-02-25 17:55:01 -08:00
Sainan pushed to song-challenge at OpenWF/SpaceNinjaServer 2025-02-25 17:55:01 -08:00
88d11becc7 feat: updateSongChallenge
Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 17:02:36 -08:00
chore: simplify conversion of missionReward from PE+

It's fine, string.replace in JavaScript only replaces the first occurence so this generally works for us, and we have no correctness problems.

Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 17:00:11 -08:00
chore: simplify conversion of missionReward from PE+

It's not a mistake on DE's part, and it's not the only instance of this.

Sainan deleted branch reward-cleanup from OpenWF/SpaceNinjaServer 2025-02-25 16:58:09 -08:00
Sainan pushed to main at OpenWF/SpaceNinjaServer 2025-02-25 16:58:08 -08:00
3945359e7d chore: simplify conversion of missionReward from PE+ (#1018)
Sainan merged pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:58:07 -08:00
chore: simplify conversion of missionReward from PE+
Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:57:51 -08:00
chore: simplify conversion of missionReward from PE+

Yes, DE is wrong, it's surely not our code that's making stupid assumption.

Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:56:34 -08:00
chore: simplify conversion of missionReward from PE+

Bro.

  • Normal: /Lotus/Types/StoreItems/AvatarImages/ImageGaussVED
  • Store item: /Lotus/StoreItems/Types/StoreItems/AvatarImages/ImageGaussVED
Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:55:04 -08:00
chore: simplify conversion of missionReward from PE+

That's exactly what I'm saying is wrong with the logic.

Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:54:16 -08:00
chore: simplify conversion of missionReward from PE+

That's not a store item.

Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:52:01 -08:00
chore: simplify conversion of missionReward from PE+

Example: /Lotus/Types/StoreItems/AvatarImages/ImageGaussVED :)

I'd say the data is as close to perfect as it gets, it's just a matter of respecting the 'types'.

Sainan commented on pull request OpenWF/SpaceNinjaServer#1018 2025-02-25 16:35:37 -08:00
chore: simplify conversion of missionReward from PE+

The additional check does harm because /StoreItems/ may be a substring of a non-StoreItem. Also if we assume the data is inaccurate, then we have a lot of other problems.

Sainan pushed to library-daily-task at OpenWF/SpaceNinjaServer 2025-02-25 16:30:11 -08:00
cd32f31878 feat: library daily task progress