OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 43 Pull Requests 4 Actions Packages Projects Releases Activity

feat: Quests 2 #878

Merged
OrdisPrime merged 5 commits from Quests2 into main 2025-02-01 07:26:02 -08:00
Conversation 2 Commits 5 Files Changed 15 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ef9dab75f9 - Show all commits

3
src/controllers/api/updateQuestController.ts
View File

@ -4,7 +4,7 @@ import { logger } from "@/src/utils/logger";
import { getJSONfromString } from "@/src/helpers/stringHelpers";
import { updateQuestKey, IUpdateQuestRequest } from "@/src/services/questService";
import { getQuestCompletionItems } from "@/src/services/itemDataService";
import { addItem, addItems, combineInventoryChanges, getInventory } from "@/src/services/inventoryService";
import { addItems, getInventory } from "@/src/services/inventoryService";
OrdisPrime marked this conversation as resolved Outdated
coderabbitai[bot] commented 2025-01-31 14:04:17 -08:00 (Migrated from github.com)
Outdated
Review
Copy Link

⚠️ Potential issue

Remove unused imports.

The imports addItem and combineInventoryChanges are no longer used in the code. This is causing build failures.

Apply this diff to fix the build:

-import { addItem, addItems, combineInventoryChanges, getInventory } from "@/src/services/inventoryService";
+import { addItems, getInventory } from "@/src/services/inventoryService";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

import { addItems, getInventory } from "@/src/services/inventoryService";
🧰 Tools
🪛 GitHub Check: build (22)

[failure] 7-7:
'addItem' is defined but never used

[failure] 7-7:
'combineInventoryChanges' is defined but never used

🪛 GitHub Check: build (20)

[failure] 7-7:
'addItem' is defined but never used

[failure] 7-7:
'combineInventoryChanges' is defined but never used

🪛 GitHub Check: build (18)

[failure] 7-7:
'addItem' is defined but never used

[failure] 7-7:
'combineInventoryChanges' is defined but never used

🪛 ESLint

[error] 7-7: 'addItem' is defined but never used.

(@typescript-eslint/no-unused-vars)

[error] 7-7: 'combineInventoryChanges' is defined but never used.

(@typescript-eslint/no-unused-vars)

🪛 GitHub Actions: Build

[error] 7-7: 'addItem' is defined but never used

_:warning: Potential issue_ **Remove unused imports.** The imports `addItem` and `combineInventoryChanges` are no longer used in the code. This is causing build failures. Apply this diff to fix the build: ```diff -import { addItem, addItems, combineInventoryChanges, getInventory } from "@/src/services/inventoryService"; +import { addItems, getInventory } from "@/src/services/inventoryService"; ``` <!-- suggestion_start --> <details> <summary>📝 Committable suggestion</summary> > ‼️ **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion import { addItems, getInventory } from "@/src/services/inventoryService"; ````` </details> <!-- suggestion_end --> <details> <summary>🧰 Tools</summary> <details> <summary>🪛 GitHub Check: build (22)</summary> [failure] 7-7: 'addItem' is defined but never used --- [failure] 7-7: 'combineInventoryChanges' is defined but never used </details> <details> <summary>🪛 GitHub Check: build (20)</summary> [failure] 7-7: 'addItem' is defined but never used --- [failure] 7-7: 'combineInventoryChanges' is defined but never used </details> <details> <summary>🪛 GitHub Check: build (18)</summary> [failure] 7-7: 'addItem' is defined but never used --- [failure] 7-7: 'combineInventoryChanges' is defined but never used </details> <details> <summary>🪛 ESLint</summary> [error] 7-7: 'addItem' is defined but never used. (@typescript-eslint/no-unused-vars) --- [error] 7-7: 'combineInventoryChanges' is defined but never used. (@typescript-eslint/no-unused-vars) </details> <details> <summary>🪛 GitHub Actions: Build</summary> [error] 7-7: 'addItem' is defined but never used </details> </details> <!-- This is an auto-generated comment by CodeRabbit -->
// eslint-disable-next-line @typescript-eslint/no-misused-promises
export const updateQuestController: RequestHandler = async (req, res) => {
@ -27,6 +27,7 @@ export const updateQuestController: RequestHandler = async (req, res) => {
logger.debug(`quest completion items`, questCompletionItems);
const inventoryChanges = await addItems(inventory, questCompletionItems);
inventory.ActiveQuest = "";
await inventory.save();
res.json({ MissionRewards: [], inventoryChanges });

1
src/services/inboxService.ts
View File

@ -46,7 +46,6 @@ export const createNewEventMessages = async (req: Request) => {
prev.eventMessageDate > current.eventMessageDate ? prev : current
);
console.log("latestEventMessage", latestEventMessage);
account.LatestEventMessageDate = new Date(latestEventMessage.eventMessageDate);
await account.save();
};