OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Activity

feat: import #831

Merged
Sainan merged 39 commits from import into main 2025-01-20 03:19:32 -08:00
Conversation 3 Commits 39 Files Changed 18 +5
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2baeae4b06 - Show all commits

5
src/services/importService.ts
View File

@ -172,6 +172,11 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
db[key] = client[key]; db[key] = client[key];
} }
} }
for (const key of ["EquippedGear", "EquippedEmotes"] as const) {
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
if (client[key]) {
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
db[key] = client[key];
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
}
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
}
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
if (client.CurrentLoadOutIds) { if (client.CurrentLoadOutIds) {
db.CurrentLoadOutIds = client.CurrentLoadOutIds; db.CurrentLoadOutIds = client.CurrentLoadOutIds;
} }

coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
coderabbitai[bot] commented 2025-01-19 23:54:40 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Consider using transactions for atomic operations.

The importInventory function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction.

Additionally, the function should validate the client object structure before processing.

 export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
+    if (!db || !client) {
+        throw new Error('Invalid arguments: db and client are required');
+    }
+
+    // Validate required client properties
+    const requiredKeys = ['WeaponSkins', 'Upgrades'];
+    for (const key of requiredKeys) {
+        if (client[key] && !Array.isArray(client[key])) {
+            throw new Error(`Invalid ${key} format: expected array`);
+        }
+    }

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Consider using transactions for atomic operations.** The `importInventory` function performs multiple updates that should be atomic. Consider wrapping the operations in a transaction. Additionally, the function should validate the client object structure before processing. ```diff export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => { + if (!db || !client) { + throw new Error('Invalid arguments: db and client are required'); + } + + // Validate required client properties + const requiredKeys = ['WeaponSkins', 'Upgrades']; + for (const key of requiredKeys) { + if (client[key] && !Array.isArray(client[key])) { + throw new Error(`Invalid ${key} format: expected array`); + } + } ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->