From 740590dcba41fb7f25e2345f7ad217fd60e7e0df Mon Sep 17 00:00:00 2001 From: Sainan Date: Sun, 19 Jan 2025 04:52:28 +0100 Subject: [PATCH 1/2] chore: handle addMiscItems leaving account with 0 or less of an item --- src/services/inventoryService.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts index c58a17df..4009ecaa 100644 --- a/src/services/inventoryService.ts +++ b/src/services/inventoryService.ts @@ -661,7 +661,13 @@ export const addMiscItems = (inventory: TInventoryDatabaseDocument, itemsArray: if (itemIndex !== -1) { MiscItems[itemIndex].ItemCount += ItemCount; - inventory.markModified(`MiscItems.${itemIndex}.ItemCount`); + if (MiscItems[itemIndex].ItemCount <= 0) { + if (MiscItems[itemIndex].ItemCount == 0) { + MiscItems.splice(itemIndex, 1); + } else { + logger.warn(`account now owns a negative amount of ${ItemType}`); + } + } } else { MiscItems.push({ ItemCount, ItemType }); } -- 2.47.2 From 80a62244a1b696acf5eea7b2c1d71f942ed8e921 Mon Sep 17 00:00:00 2001 From: Sainan Date: Sun, 19 Jan 2025 04:53:12 +0100 Subject: [PATCH 2/2] chore: handle addMods leaving account with 0 or less of a mod --- src/services/inventoryService.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts index 4009ecaa..e25f9f70 100644 --- a/src/services/inventoryService.ts +++ b/src/services/inventoryService.ts @@ -729,7 +729,13 @@ export const addMods = (inventory: TInventoryDatabaseDocument, itemsArray: IRawU if (itemIndex !== -1) { RawUpgrades[itemIndex].ItemCount += ItemCount; - inventory.markModified(`RawUpgrades.${itemIndex}.ItemCount`); + if (RawUpgrades[itemIndex].ItemCount <= 0) { + if (RawUpgrades[itemIndex].ItemCount == 0) { + RawUpgrades.splice(itemIndex, 1); + } else { + logger.warn(`account now owns a negative amount of ${ItemType}`); + } + } } else { RawUpgrades.push({ ItemCount, ItemType }); } -- 2.47.2