From 4072ecfba0d6f7180cdd23513795f0d667f2b503 Mon Sep 17 00:00:00 2001 From: Sainan Date: Sun, 12 Jan 2025 07:56:14 +0100 Subject: [PATCH 1/2] fix: limit standing gain from medallions for title's max --- .../api/syndicateStandingBonusController.ts | 30 ++++++++++++++----- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/src/controllers/api/syndicateStandingBonusController.ts b/src/controllers/api/syndicateStandingBonusController.ts index 50854951..581da13c 100644 --- a/src/controllers/api/syndicateStandingBonusController.ts +++ b/src/controllers/api/syndicateStandingBonusController.ts @@ -24,16 +24,18 @@ export const syndicateStandingBonusController: RequestHandler = async (req, res) const inventory = await getInventory(accountId); addMiscItems(inventory, request.Operation.Items); - const syndicate = inventory.Affiliations.find(x => x.Tag == request.Operation.AffiliationTag); - if (syndicate !== undefined) { - syndicate.Standing += gainedStanding; - } else { - inventory.Affiliations.push({ - Tag: request.Operation.AffiliationTag, - Standing: gainedStanding - }); + let syndicate = inventory.Affiliations.find(x => x.Tag == request.Operation.AffiliationTag); + if (!syndicate) { + syndicate = inventory.Affiliations[inventory.Affiliations.push({ Tag: request.Operation.AffiliationTag, Standing: 0 })]; } + const max = getMaxStanding(request.Operation.AffiliationTag, syndicate.Title ?? 0); + if (syndicate.Standing + gainedStanding > max) { + gainedStanding = max - syndicate.Standing; + } + + syndicate.Standing += gainedStanding; + // TODO: Subtract from daily limit bin; maybe also a cheat to skip that. await inventory.save(); @@ -59,3 +61,15 @@ interface ISyndicateStandingBonusRequest { }; ModularWeaponId: IOid; // Seems to just be "000000000000000000000000", also note there's a "Category" query field } + +const getMaxStanding = (affiliationTag: string, title: number): number => { + const syndicate = ExportSyndicates[affiliationTag]; + if (!syndicate.titles) { + // LibrarySyndicate + return 125000; + } + if (title == 0) { + return syndicate.titles.find(x => x.level == 1)!.minStanding; + } + return syndicate.titles.find(x => x.level == title)!.maxStanding; +}; -- 2.47.2 From 3890e3193b100c8aa5710bd55f4bb845eaf3f29d Mon Sep 17 00:00:00 2001 From: Sainan Date: Sun, 12 Jan 2025 07:58:18 +0100 Subject: [PATCH 2/2] prettier --- src/controllers/api/syndicateStandingBonusController.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/controllers/api/syndicateStandingBonusController.ts b/src/controllers/api/syndicateStandingBonusController.ts index 581da13c..4513f25f 100644 --- a/src/controllers/api/syndicateStandingBonusController.ts +++ b/src/controllers/api/syndicateStandingBonusController.ts @@ -26,7 +26,8 @@ export const syndicateStandingBonusController: RequestHandler = async (req, res) let syndicate = inventory.Affiliations.find(x => x.Tag == request.Operation.AffiliationTag); if (!syndicate) { - syndicate = inventory.Affiliations[inventory.Affiliations.push({ Tag: request.Operation.AffiliationTag, Standing: 0 })]; + syndicate = + inventory.Affiliations[inventory.Affiliations.push({ Tag: request.Operation.AffiliationTag, Standing: 0 })]; } const max = getMaxStanding(request.Operation.AffiliationTag, syndicate.Title ?? 0); -- 2.47.2