OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 49 Pull Requests 6 Actions Packages Projects Releases Activity

feat: fish dissection #663

Merged
Sainan merged 1 commits from dissect into main 2024-12-30 10:48:21 -08:00
Conversation 2 Commits 1 Files Changed 2 +40
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/controllers/api/fishmongerController.ts Normal file
View File

@ -0,0 +1,38 @@
import { getJSONfromString } from "@/src/helpers/stringHelpers";
import { addMiscItems, getInventory } from "@/src/services/inventoryService";
import { getAccountIdForRequest } from "@/src/services/loginService";
import { IMiscItem } from "@/src/types/inventoryTypes/inventoryTypes";
import { RequestHandler } from "express";
import { ExportResources } from "warframe-public-export-plus";
export const fishmongerController: RequestHandler = async (req, res) => {
if (!req.query.dissect) {
throw new Error("expected fishmonger request to be for dissection");
}
const accountId = await getAccountIdForRequest(req);
const inventory = await getInventory(accountId);
const body = getJSONfromString(String(req.body)) as IFishmongerRequest;
const miscItemChanges: IMiscItem[] = [];
for (const fish of body.Fish) {
for (const part of ExportResources[fish.ItemType].dissectionParts!) {
const partItem = miscItemChanges.find(x => x.ItemType == part.ItemType);
if (partItem) {
partItem.ItemCount += part.ItemCount;
} else {
miscItemChanges.push(part);
}
}
miscItemChanges.push({ ItemType: fish.ItemType, ItemCount: fish.ItemCount * -1 });
}
coderabbitai[bot] commented 2024-12-29 16:52:32 -08:00 (Migrated from github.com)
Review
Copy Link

🛠️ Refactor suggestion

Check for invalid item types to avoid undefined references.
ExportResources[fish.ItemType] might be undefined if fish.ItemType is invalid or missing from ExportResources. Before accessing .dissectionParts, ensure that ExportResources[fish.ItemType] is valid.

 for (const fish of body.Fish) {
+    if (!ExportResources[fish.ItemType] || !ExportResources[fish.ItemType].dissectionParts) {
+        // handle invalid fish item type or missing dissectionParts
+        continue;
+    }
     for (const part of ExportResources[fish.ItemType].dissectionParts!) {
         ...

Committable suggestion skipped: line range outside the PR's diff.

_:hammer_and_wrench: Refactor suggestion_ **Check for invalid item types to avoid undefined references.** `ExportResources[fish.ItemType]` might be undefined if `fish.ItemType` is invalid or missing from `ExportResources`. Before accessing `.dissectionParts`, ensure that `ExportResources[fish.ItemType]` is valid. ```diff for (const fish of body.Fish) { + if (!ExportResources[fish.ItemType] || !ExportResources[fish.ItemType].dissectionParts) { + // handle invalid fish item type or missing dissectionParts + continue; + } for (const part of ExportResources[fish.ItemType].dissectionParts!) { ... ``` > Committable suggestion skipped: line range outside the PR's diff. <!-- This is an auto-generated comment by CodeRabbit -->
addMiscItems(inventory, miscItemChanges);
await inventory.save();
res.json({
InventoryChanges: {
MiscItems: miscItemChanges
}
});
};
interface IFishmongerRequest {
Fish: IMiscItem[];
}

2
src/routes/api.ts
View File

@ -11,6 +11,7 @@ import { dronesController } from "@/src/controllers/api/dronesController";
import { endlessXpController } from "@/src/controllers/api/endlessXpController";
import { evolveWeaponController } from "@/src/controllers/api/evolveWeaponController";
import { findSessionsController } from "@/src/controllers/api/findSessionsController";
import { fishmongerController } from "@/src/controllers/api/fishmongerController";
import { focusController } from "@/src/controllers/api/focusController";
import { fusionTreasuresController } from "@/src/controllers/api/fusionTreasuresController";
import { genericUpdateController } from "@/src/controllers/api/genericUpdateController";
@ -113,6 +114,7 @@ apiRouter.post("/createGuild.php", createGuildController);
apiRouter.post("/endlessXp.php", endlessXpController);
apiRouter.post("/evolveWeapon.php", evolveWeaponController);
apiRouter.post("/findSessions.php", findSessionsController);
apiRouter.post("/fishmonger.php", fishmongerController);
apiRouter.post("/focus.php", focusController);
apiRouter.post("/fusionTreasures.php", fusionTreasuresController);
apiRouter.post("/genericUpdate.php", genericUpdateController);