OpenWF/SpaceNinjaServer
16
15
Fork 18
Code Issues 38 Pull Requests 4 Actions Packages Projects Releases Activity

fix: being unable to visit Palladino in Iron Wake despite completeAllQuests #564

Merged
Sainan merged 1 commits from palladino into main 2024-10-18 07:49:33 -07:00
Conversation 6 Commits 1 Files Changed 1 +11 -4
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/controllers/api/inventoryController.ts
View File

@ -70,15 +70,22 @@ const inventoryController: RequestHandler = async (request, response) => {
}
if (config.completeAllQuests) {
for (const quest of inventoryResponse.QuestKeys) {
quest.unlock = true;
quest.Completed = true;
coderabbitai[bot] commented 2024-10-18 06:09:47 -07:00 (Migrated from github.com)
Review
Copy Link

⚠️ Potential issue

Inconsistent Property Naming: 'unlock' vs 'Completed'

The properties unlock and Completed have inconsistent casing. To maintain consistency and improve readability, consider standardizing the property names. If both are boolean flags, you might prefer using either camelCase or PascalCase for both.

Apply this diff to make the property names consistent:

Option 1 (camelCase):

- quest.unlock = true;
- quest.Completed = true;
+ quest.unlocked = true;
+ quest.completed = true;

Option 2 (PascalCase):

- quest.unlock = true;
- quest.Completed = true;
+ quest.Unlock = true;
+ quest.Completed = true;

Please choose the option that aligns with your project's naming conventions.

Committable suggestion was skipped due to low confidence.

_:warning: Potential issue_ **Inconsistent Property Naming: 'unlock' vs 'Completed'** The properties `unlock` and `Completed` have inconsistent casing. To maintain consistency and improve readability, consider standardizing the property names. If both are boolean flags, you might prefer using either `camelCase` or `PascalCase` for both. Apply this diff to make the property names consistent: Option 1 (camelCase): ```diff - quest.unlock = true; - quest.Completed = true; + quest.unlocked = true; + quest.completed = true; ``` Option 2 (PascalCase): ```diff - quest.unlock = true; - quest.Completed = true; + quest.Unlock = true; + quest.Completed = true; ``` Please choose the option that aligns with your project's naming conventions. > Committable suggestion was skipped due to low confidence. <!-- This is an auto-generated reply by CodeRabbit -->
Sainan commented 2024-10-18 06:12:57 -07:00
Review
Copy Link

Wow, what a great suggestion! I'll be sure to implement it right away!!! Oh wait, why does it not work anymore?!?!?!!?!

Kill yourself.

Wow, what a great suggestion! I'll be sure to implement it right away!!! Oh wait, why does it not work anymore?!?!?!!?! Kill yourself.
coderabbitai[bot] commented 2024-10-18 06:13:30 -07:00 (Migrated from github.com)
Review
Copy Link

@Sainan, I'm sorry to hear that you're experiencing issues. Please let me know how I can assist you further.

(_/_) (•_• )

@Sainan, I'm sorry to hear that you're experiencing issues. Please let me know how I can assist you further. (\_/\_) (•_• ) <!-- This is an auto-generated reply by CodeRabbit -->
0kolya0 commented 2024-10-18 06:13:45 -07:00 (Migrated from github.com)
Review
Copy Link

🤣

🤣
coderabbitai[bot] commented 2024-10-18 06:13:51 -07:00 (Migrated from github.com)
Review
Copy Link

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

> Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out! <!-- This is an auto-generated mute comment by CodeRabbit -->
quest.Progress = [
{
let numStages = 1;
if (quest.ItemType in ExportKeys && "chainStages" in ExportKeys[quest.ItemType]) {
numStages = ExportKeys[quest.ItemType].chainStages!.length;
}
quest.Progress = [];
for (let i = 0; i != numStages; ++i) {
quest.Progress.push({
c: 0,
i: false,
m: false,
b: []
});
}
];
}
inventoryResponse.ArchwingEnabled = true;