OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 42 Pull Requests 2 Actions Packages Projects Releases Activity

feat: gilded weapons #410

Merged
AMelonInsideLemon merged 4 commits from gildWeapon into main 2024-06-27 01:21:02 -07:00
Conversation 7 Commits 4 Files Changed 3 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b8864d4399 - Show all commits

2
src/controllers/api/gildWeaponController.ts
View File

@ -35,7 +35,7 @@ export const gildWeaponController: RequestHandler = async (req, res) => {
OrdisPrime commented 2024-06-26 07:16:33 -07:00 (Migrated from github.com)
Review
Copy Link

caterogy

caterogy
OrdisPrime commented 2024-06-26 07:16:33 -07:00 (Migrated from github.com)
Review
Copy Link

caterogy

caterogy
OrdisPrime commented 2024-06-26 07:17:09 -07:00 (Migrated from github.com)
Review
Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing
OrdisPrime commented 2024-06-26 07:17:09 -07:00 (Migrated from github.com)
Review
Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing
AMelonInsideLemon commented 2024-06-26 07:38:23 -07:00 (Migrated from github.com)
Review
Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter
AMelonInsideLemon commented 2024-06-26 07:38:23 -07:00 (Migrated from github.com)
Review
Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter
FSKiller commented 2024-06-26 08:05:16 -07:00 (Migrated from github.com)
Review
Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"
FSKiller commented 2024-06-26 08:05:16 -07:00 (Migrated from github.com)
Review
Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"
AMelonInsideLemon commented 2024-06-26 08:07:00 -07:00 (Migrated from github.com)
Review
Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep
AMelonInsideLemon commented 2024-06-26 08:07:00 -07:00 (Migrated from github.com)
Review
Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep
OrdisPrime commented 2024-06-26 08:23:30 -07:00 (Migrated from github.com)
Review
Copy Link

all good lmao, sleep well.

all good lmao, sleep well.
OrdisPrime commented 2024-06-26 08:23:30 -07:00 (Migrated from github.com)
Review
Copy Link

all good lmao, sleep well.

all good lmao, sleep well.
data.Category = req.query.Category as WeaponTypeInternal | "Hoverboards"; data.Category = req.query.Category as WeaponTypeInternal | "Hoverboards";
const inventory = await getInventory(accountId); const inventory = await getInventory(accountId);
if(!inventory[data.Category]) { if (!inventory[data.Category]) {
OrdisPrime commented 2024-06-26 07:16:33 -07:00 (Migrated from github.com)
Review
Copy Link

caterogy

caterogy
OrdisPrime commented 2024-06-26 07:17:09 -07:00 (Migrated from github.com)
Review
Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing
AMelonInsideLemon commented 2024-06-26 07:38:23 -07:00 (Migrated from github.com)
Review
Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter
FSKiller commented 2024-06-26 08:05:16 -07:00 (Migrated from github.com)
Review
Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"
AMelonInsideLemon commented 2024-06-26 08:07:00 -07:00 (Migrated from github.com)
Review
Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep
OrdisPrime commented 2024-06-26 08:23:30 -07:00 (Migrated from github.com)
Review
Copy Link

all good lmao, sleep well.

all good lmao, sleep well.
OrdisPrime commented 2024-06-26 07:16:33 -07:00 (Migrated from github.com)
Review
Copy Link

caterogy

caterogy
OrdisPrime commented 2024-06-26 07:17:09 -07:00 (Migrated from github.com)
Review
Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing
AMelonInsideLemon commented 2024-06-26 07:38:23 -07:00 (Migrated from github.com)
Review
Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter
FSKiller commented 2024-06-26 08:05:16 -07:00 (Migrated from github.com)
Review
Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"
AMelonInsideLemon commented 2024-06-26 08:07:00 -07:00 (Migrated from github.com)
Review
Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep
OrdisPrime commented 2024-06-26 08:23:30 -07:00 (Migrated from github.com)
Review
Copy Link

all good lmao, sleep well.

all good lmao, sleep well.
throw new Error(`Category ${req.query.Category} not found in inventory`); throw new Error(`Category ${req.query.Category} not found in inventory`);
} }
const weaponIndex = inventory[data.Category].findIndex(x => String(x._id) === data.ItemId); const weaponIndex = inventory[data.Category].findIndex(x => String(x._id) === data.ItemId);

OrdisPrime commented 2024-06-26 07:16:33 -07:00 (Migrated from github.com)
Review
Copy Link

caterogy

caterogy
OrdisPrime commented 2024-06-26 07:16:33 -07:00 (Migrated from github.com)
Review
Copy Link

caterogy

caterogy
OrdisPrime commented 2024-06-26 07:17:09 -07:00 (Migrated from github.com)
Review
Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing
OrdisPrime commented 2024-06-26 07:17:09 -07:00 (Migrated from github.com)
Review
Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing
AMelonInsideLemon commented 2024-06-26 07:38:23 -07:00 (Migrated from github.com)
Review
Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter
AMelonInsideLemon commented 2024-06-26 07:38:23 -07:00 (Migrated from github.com)
Review
Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter
FSKiller commented 2024-06-26 08:05:16 -07:00 (Migrated from github.com)
Review
Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"
FSKiller commented 2024-06-26 08:05:16 -07:00 (Migrated from github.com)
Review
Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"
AMelonInsideLemon commented 2024-06-26 08:07:00 -07:00 (Migrated from github.com)
Review
Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep
AMelonInsideLemon commented 2024-06-26 08:07:00 -07:00 (Migrated from github.com)
Review
Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep
OrdisPrime commented 2024-06-26 08:23:30 -07:00 (Migrated from github.com)
Review
Copy Link

all good lmao, sleep well.

all good lmao, sleep well.
OrdisPrime commented 2024-06-26 08:23:30 -07:00 (Migrated from github.com)
Review
Copy Link

all good lmao, sleep well.

all good lmao, sleep well.