From 51dad17ae10143038cd5ef07b334b541f4349c50 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Fri, 24 Oct 2025 15:57:56 +0200 Subject: [PATCH 1/2] Revert "fix: only commit 'Missions' on successful completion (#2866)" This reverts commit f5c1b8359895df5966c50d9a6aac733b22c25450. --- src/services/missionInventoryUpdateService.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index 336efe87..c8e0f50c 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -310,6 +310,9 @@ export const addMissionInventoryUpdates = async ( } break; } + case "Missions": + addMissionComplete(inventory, value); + break; case "LastRegionPlayed": if (!(config.unfaithfulBugFixes?.ignore1999LastRegionPlayed && value === "1999MapName")) { inventory.LastRegionPlayed = value; @@ -1242,9 +1245,6 @@ export const addMissionRewards = async ( if (missions && missions.Tag in ExportRegions) { const node = ExportRegions[missions.Tag]; - // cannot add this with normal updates because { Tier: 1 } would mark the SP node as completed even on a failure - addMissionComplete(inventory, missions); - //node based credit rewards for mission completion if (isEligibleForCreditReward(rewardInfo, missions, node)) { const levelCreditReward = getLevelCreditRewards(node); -- 2.47.2 From 799e530bef12d67e524a316df92f792299408793 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Fri, 24 Oct 2025 16:01:06 +0200 Subject: [PATCH 2/2] fix: junction completion on steel path doesn't save --- src/services/inventoryService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts index 17cdf370..7e348cc4 100644 --- a/src/services/inventoryService.ts +++ b/src/services/inventoryService.ts @@ -2172,7 +2172,7 @@ export const addMissionComplete = (inventory: TInventoryDatabaseDocument, { Tag, if (itemIndex !== -1) { Missions[itemIndex].Completes += Completes; - if (Tier) { + if (Completes && Tier) { Missions[itemIndex].Tier = Tier; } } else { -- 2.47.2