OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Activity

feat: Void Corruption 2025 #2865

Merged
Sainan merged 39 commits from Slayer55555/SpaceNinjaServer:void-alerts into main 2025-10-09 00:28:35 -07:00
Conversation 22 Commits 39 Files Changed 14 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 05722da681 - Show all commits

2
src/types/inventoryTypes/inventoryTypes.ts
View File

@ -314,7 +314,7 @@ export interface IInventoryClient extends IDailyAffiliations, InventoryClientEqu
DeathMarks: string[];
FusionTreasures: IFusionTreasure[];
//WebFlags: IWebFlags;
CompletedAlerts: string[];
CompletedAlerts?: string[];
Slayer55555 marked this conversation as resolved Outdated
AMelonInsideLemon commented 2025-10-06 15:10:19 -07:00
Outdated
Review
Copy Link

This field has been in all inventories for at least 20 months. Why are you making it optional?

This field has been in all inventories for at least 20 months. Why are you making it optional?
Slayer55555 commented 2025-10-06 16:59:58 -07:00
Outdated
Review
Copy Link

npm run verify fails if it's not optional

`npm run verify` fails if it's not optional
AMelonInsideLemon commented 2025-10-06 17:04:53 -07:00
Outdated
Review
Copy Link

npm run verify doesn't fails because of that
npm run lint:ci fails because there is useless inventory.CompletedAlerts ??= [];

`npm run verify` doesn't fails because of that `npm run lint:ci` fails because there is useless `inventory.CompletedAlerts ??= [];`
Slayer55555 commented 2025-10-06 17:19:01 -07:00
Outdated
Review
Copy Link

Ohhh, I will try to fix it later, thanks.

Ohhh, I will try to fix it later, thanks.
Consumables: ITypeCount[];
LevelKeys: ITypeCount[];
TauntHistory?: ITaunt[];