OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Activity

WIP: fix: avoid pushing to quest progress in updateQuestStage #2847

Closed
Sainan wants to merge 7 commits from quest-fix into main
pull from: quest-fix
merge into: OpenWF:main
Conversation 1 Commits 7 Files Changed 4 +9 -3
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 37c2da0f8e - Show all commits

12
src/services/questService.ts
View File

@ -83,10 +83,16 @@ export const updateQuestStage = (
`Quest stage index mismatch: stage is ${ChainStage} but array size is ${quest.Progress.length}` `Quest stage index mismatch: stage is ${ChainStage} but array size is ${quest.Progress.length}`
); );
} }
const questStage = quest.Progress[ChainStage]; // guaranteed in-bounds now // Note that the client may use index 0 as well, e.g. for rising tide's initial inbox message. 'm' is not tracked for it.
if (ChainStage >= 0) {
const questStage = quest.Progress[ChainStage]; // guaranteed in-bounds now
for (const [key, value] of Object.entries(questStageUpdate) as [keyof IQuestStage, number | boolean | any[]][]) { for (const [key, value] of Object.entries(questStageUpdate) as [
(questStage[key] as any) = value; keyof IQuestStage,
number | boolean | any[]
][]) {
(questStage[key] as any) = value;
}
} }
}; };