feat: syndicates #269

Merged
janisslsm merged 4 commits from feat-syndicate into main 2024-06-02 08:35:06 -07:00
4 changed files with 4 additions and 23 deletions
Showing only changes of commit 00740e31dd - Show all commits

View File

@ -1,14 +0,0 @@
Review

This file isn't needed.

This file isn't needed.
Review

This file isn't needed.

This file isn't needed.
import { updateSyndicate } from "@/src/services/inventoryService";
Review

This file isn't needed.

This file isn't needed.
import { RequestHandler } from "express";
Review

This file isn't needed.

This file isn't needed.
Review

This file isn't needed.

This file isn't needed.
// eslint-disable-next-line @typescript-eslint/no-misused-promises
Review

This file isn't needed.

This file isn't needed.
const setSupportedSyndicateController: RequestHandler = async (request, response) => {
Review

This file isn't needed.

This file isn't needed.
const accountId = request.query.accountId as string;
Review

This file isn't needed.

This file isn't needed.
const syndicate = request.query.syndicate as string;
Review

This file isn't needed.

This file isn't needed.
Review

This file isn't needed.

This file isn't needed.
await updateSyndicate(syndicate, accountId);
Review

This file isn't needed.

This file isn't needed.
Review

This file isn't needed.

This file isn't needed.
response.json({});
Review

This file isn't needed.

This file isn't needed.
};
Review

This file isn't needed.

This file isn't needed.
Review

This file isn't needed.

This file isn't needed.
export { setSupportedSyndicateController };
Review

This file isn't needed.

This file isn't needed.

View File

@ -2,11 +2,11 @@ import { getJSONfromString } from "@/src/helpers/stringHelpers";
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
import { syndicateSacrifice } from "@/src/services/inventoryService"; import { syndicateSacrifice } from "@/src/services/inventoryService";
import { ISyndicateSacrifice } from "@/src/types/syndicateTypes"; import { ISyndicateSacrifice } from "@/src/types/syndicateTypes";
import { RequestHandler } from "express"; import { RequestHandler } from "express";
import { getAccountIdForRequest } from "@/src/services/loginService";
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
// eslint-disable-next-line @typescript-eslint/no-misused-promises // eslint-disable-next-line @typescript-eslint/no-misused-promises
const syndicateSacrificeController: RequestHandler = async (request, response) => { const syndicateSacrificeController: RequestHandler = async (request, response) => {
const accountId = request.query.accountId as string; const accountId = await getAccountIdForRequest(request);
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
const body = getJSONfromString(request.body); const body = getJSONfromString(request.body);
let reply = {}; let reply = {};
try { try {

Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```
Review

Should use getAccountIdForRequest so nonce is validated here

import { getAccountIdForRequest } from "@/src/services/loginService";
Should use getAccountIdForRequest so nonce is validated here ```ts import { getAccountIdForRequest } from "@/src/services/loginService"; ```

View File

@ -52,6 +52,7 @@ import { getGuildLogController } from "../controllers/api/getGuildLogController"
import { guildTechController } from "../controllers/api/guildTechController"; import { guildTechController } from "../controllers/api/guildTechController";
import { dojoController } from "@/src/controllers/api/dojoController"; import { dojoController } from "@/src/controllers/api/dojoController";
import { getGuildDojoController } from "@/src/controllers/api/getGuildDojoController"; import { getGuildDojoController } from "@/src/controllers/api/getGuildDojoController";
import { syndicateSacrificeController } from "../controllers/api/syndicateSacrificeController";
const apiRouter = express.Router(); const apiRouter = express.Router();
@ -114,5 +115,6 @@ apiRouter.post("/createGuild.php", createGuildController);
apiRouter.post("/sell.php", sellController); apiRouter.post("/sell.php", sellController);
apiRouter.post("/upgrades.php", upgradesController); apiRouter.post("/upgrades.php", upgradesController);
apiRouter.post("/guildTech.php", guildTechController); apiRouter.post("/guildTech.php", guildTechController);
apiRouter.post("/syndicateSacrifice.php", syndicateSacrificeController);
export { apiRouter }; export { apiRouter };

View File

@ -185,13 +185,6 @@ export const syndicateSacrifice = async (data: ISyndicateSacrifice, accountId: s
return res; return res;
}; };
export const updateSyndicate = async (syndicate: string, accountId: string) => {
const inventory = await getInventory(accountId);
inventory.SupportedSyndicate = syndicate;
await inventory.save();
};
export const addWeapon = async ( export const addWeapon = async (
weaponType: WeaponTypeInternal, weaponType: WeaponTypeInternal,
weaponName: string, weaponName: string,