From 6073ab6d369047d68b3474f2b5e081230936c008 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sat, 26 Jul 2025 21:07:08 +0200 Subject: [PATCH 1/2] fix: correctly apply riven cipher The completeRandomModChallenge endpoint is only supposed to complete the challenge, what a shocker. Because we directly set a unveiled fingerprint, the game was not showing the expected UI. --- .../api/completeRandomModChallengeController.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/controllers/api/completeRandomModChallengeController.ts b/src/controllers/api/completeRandomModChallengeController.ts index a4e3cf08..247d9aa0 100644 --- a/src/controllers/api/completeRandomModChallengeController.ts +++ b/src/controllers/api/completeRandomModChallengeController.ts @@ -4,8 +4,7 @@ import { addMiscItems, getInventory, updateCurrency } from "@/src/services/inven import { IInventoryChanges } from "@/src/types/purchaseTypes"; import { IMiscItem } from "@/src/types/inventoryTypes/inventoryTypes"; import { getJSONfromString } from "@/src/helpers/stringHelpers"; -import { createUnveiledRivenFingerprint } from "@/src/helpers/rivenHelper"; -import { ExportUpgrades } from "warframe-public-export-plus"; +import { IVeiledRivenFingerprint } from "@/src/helpers/rivenHelper"; export const completeRandomModChallengeController: RequestHandler = async (req, res) => { const accountId = await getAccountIdForRequest(req); @@ -29,8 +28,9 @@ export const completeRandomModChallengeController: RequestHandler = async (req, // Update riven fingerprint to a randomised unveiled state const upgrade = inventory.Upgrades.id(request.ItemId)!; - const meta = ExportUpgrades[upgrade.ItemType]; - upgrade.UpgradeFingerprint = JSON.stringify(createUnveiledRivenFingerprint(meta)); + const fp = JSON.parse(upgrade.UpgradeFingerprint!) as IVeiledRivenFingerprint; + fp.challenge.Progress = fp.challenge.Required; + upgrade.UpgradeFingerprint = JSON.stringify(fp); await inventory.save(); -- 2.47.2 From a268ae69577be5ddf25856bde7380c99255cb6d9 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sat, 26 Jul 2025 21:08:16 +0200 Subject: [PATCH 2/2] update comment --- src/controllers/api/completeRandomModChallengeController.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/controllers/api/completeRandomModChallengeController.ts b/src/controllers/api/completeRandomModChallengeController.ts index 247d9aa0..0400c2b0 100644 --- a/src/controllers/api/completeRandomModChallengeController.ts +++ b/src/controllers/api/completeRandomModChallengeController.ts @@ -26,7 +26,7 @@ export const completeRandomModChallengeController: RequestHandler = async (req, inventoryChanges.MiscItems = miscItemChanges; } - // Update riven fingerprint to a randomised unveiled state + // Complete the riven challenge const upgrade = inventory.Upgrades.id(request.ItemId)!; const fp = JSON.parse(upgrade.UpgradeFingerprint!) as IVeiledRivenFingerprint; fp.challenge.Progress = fp.challenge.Required; -- 2.47.2