OpenWF/SpaceNinjaServer
17
19
Fork 22
Code Issues 31 Pull Requests 5 Actions Packages Projects Releases Activity

chore: report unknown fields in updateChallengeProgress payload #2210

Merged
Sainan merged 1 commits from challenge-warn into main 2025-06-19 16:18:50 -07:00
Conversation 0 Commits 1 Files Changed 1 +27 -12
1 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2ca7ba0574 - Show all commits

39
src/controllers/api/updateChallengeProgressController.ts
View File

@ -4,6 +4,8 @@ import { getAccountForRequest } from "@/src/services/loginService";
import { addChallenges, getInventory } from "@/src/services/inventoryService"; import { addChallenges, getInventory } from "@/src/services/inventoryService";
import { IChallengeProgress, ISeasonChallenge } from "@/src/types/inventoryTypes/inventoryTypes"; import { IChallengeProgress, ISeasonChallenge } from "@/src/types/inventoryTypes/inventoryTypes";
import { IAffiliationMods } from "@/src/types/purchaseTypes"; import { IAffiliationMods } from "@/src/types/purchaseTypes";
import { getEntriesUnsafe } from "@/src/utils/ts-utils";
import { logger } from "@/src/utils/logger";
export const updateChallengeProgressController: RequestHandler = async (req, res) => { export const updateChallengeProgressController: RequestHandler = async (req, res) => {
const challenges = getJSONfromString<IUpdateChallengeProgressRequest>(String(req.body)); const challenges = getJSONfromString<IUpdateChallengeProgressRequest>(String(req.body));
@ -13,9 +15,6 @@ export const updateChallengeProgressController: RequestHandler = async (req, res
account._id.toString(), account._id.toString(),
"ChallengesFixVersion ChallengeProgress SeasonChallengeHistory Affiliations" "ChallengesFixVersion ChallengeProgress SeasonChallengeHistory Affiliations"
); );
if (challenges.ChallengesFixVersion !== undefined) {
inventory.ChallengesFixVersion = challenges.ChallengesFixVersion;
}
let affiliationMods: IAffiliationMods[] = []; let affiliationMods: IAffiliationMods[] = [];
if (challenges.ChallengeProgress) { if (challenges.ChallengeProgress) {
affiliationMods = addChallenges( affiliationMods = addChallenges(
@ -25,15 +24,30 @@ export const updateChallengeProgressController: RequestHandler = async (req, res
challenges.SeasonChallengeCompletions challenges.SeasonChallengeCompletions
); );
} }
if (challenges.SeasonChallengeHistory) { for (const [key, value] of getEntriesUnsafe(challenges)) {
challenges.SeasonChallengeHistory.forEach(({ challenge, id }) => { switch (key) {
const itemIndex = inventory.SeasonChallengeHistory.findIndex(i => i.challenge === challenge); case "ChallengesFixVersion":
if (itemIndex !== -1) { inventory.ChallengesFixVersion = value;
inventory.SeasonChallengeHistory[itemIndex].id = id; break;
} else {
inventory.SeasonChallengeHistory.push({ challenge, id }); case "SeasonChallengeHistory":
} value!.forEach(({ challenge, id }) => {
}); const itemIndex = inventory.SeasonChallengeHistory.findIndex(i => i.challenge === challenge);
if (itemIndex !== -1) {
inventory.SeasonChallengeHistory[itemIndex].id = id;
} else {
inventory.SeasonChallengeHistory.push({ challenge, id });
}
});
break;
case "ChallengeProgress":
case "SeasonChallengeCompletions":
case "ChallengePTS":
break;
default:
logger.warn(`unknown challenge progress entry`, { key, value });
}
} }
await inventory.save(); await inventory.save();
@ -43,6 +57,7 @@ export const updateChallengeProgressController: RequestHandler = async (req, res
}; };
interface IUpdateChallengeProgressRequest { interface IUpdateChallengeProgressRequest {
ChallengePTS?: number;
ChallengesFixVersion?: number; ChallengesFixVersion?: number;
ChallengeProgress?: IChallengeProgress[]; ChallengeProgress?: IChallengeProgress[];
SeasonChallengeHistory?: ISeasonChallenge[]; SeasonChallengeHistory?: ISeasonChallenge[];