From 34efe4625991d02be9e323855db0faf3bb60369b Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Fri, 16 May 2025 10:48:14 +0200
Subject: [PATCH 1/2] chore: auto-detect cycle duration for auto-generated
 vendors

---
 src/services/serversideVendorsService.ts | 32 +++++++++++++++++++-----
 1 file changed, 26 insertions(+), 6 deletions(-)

diff --git a/src/services/serversideVendorsService.ts b/src/services/serversideVendorsService.ts
index af7d0b91..81aacd9e 100644
--- a/src/services/serversideVendorsService.ts
+++ b/src/services/serversideVendorsService.ts
@@ -3,7 +3,7 @@ import { catBreadHash } from "@/src/helpers/stringHelpers";
 import { mixSeeds, SRng } from "@/src/services/rngService";
 import { IMongoDate } from "@/src/types/commonTypes";
 import { IItemManifest, IVendorInfo, IVendorManifest } from "@/src/types/vendorTypes";
-import { ExportVendors, IRange } from "warframe-public-export-plus";
+import { ExportVendors, IRange, IVendor } from "warframe-public-export-plus";
 
 import ArchimedeanVendorManifest from "@/static/fixed_responses/getVendorInfo/ArchimedeanVendorManifest.json";
 import DeimosEntratiFragmentVendorProductsManifest from "@/static/fixed_responses/getVendorInfo/DeimosEntratiFragmentVendorProductsManifest.json";
@@ -83,10 +83,10 @@ const generatableVendors: IGeneratableVendorInfo[] = [
         cycleDuration: 4 * unixTimesInMs.day
     },
     {
-        _id: { $oid: "61ba123467e5d37975aeeb03" },
+        _id: { $oid: "61ba123467e5d37975aeeb03" }, // The game expects this specific oid
         TypeName: "/Lotus/Types/Game/VendorManifests/Hubs/GuildAdvertisementVendorManifest",
         RandomSeedType: "VRST_FLAVOUR_TEXT",
-        cycleDuration: unixTimesInMs.week // TODO: Auto-detect this based on the items, so we don't need to specify it explicitly.
+        cycleDuration: unixTimesInMs.week
     }
     // {
     //     _id: { $oid: "5dbb4c41e966f7886c3ce939" },
@@ -98,6 +98,25 @@ const getVendorOid = (typeName: string): string => {
     return "5be4a159b144f3cd" + catBreadHash(typeName).toString(16).padStart(8, "0");
 };
 
+// https://stackoverflow.com/a/17445304
+const gcd = (a: number, b: number): number => {
+    return b ? gcd(b, a % b) : a;
+};
+
+const getCycleDuration = (manifest: IVendor): number => {
+    let dur = 0;
+    for (const item of manifest.items) {
+        if (typeof item.durationHours != "number") {
+            dur = 1;
+            break;
+        }
+        if (dur != item.durationHours) {
+            dur = gcd(dur, item.durationHours);
+        }
+    }
+    return dur * unixTimesInMs.hour;
+};
+
 export const getVendorManifestByTypeName = (typeName: string): IVendorManifest | undefined => {
     for (const vendorManifest of rawVendorManifests) {
         if (vendorManifest.VendorInfo.TypeName == typeName) {
@@ -110,11 +129,12 @@ export const getVendorManifestByTypeName = (typeName: string): IVendorManifest |
         }
     }
     if (typeName in ExportVendors) {
+        const manifest = ExportVendors[typeName];
         return generateVendorManifest({
             _id: { $oid: getVendorOid(typeName) },
             TypeName: typeName,
-            RandomSeedType: ExportVendors[typeName].randomSeedType,
-            cycleDuration: unixTimesInMs.hour
+            RandomSeedType: manifest.randomSeedType,
+            cycleDuration: getCycleDuration(manifest)
         });
     }
     return undefined;
@@ -138,7 +158,7 @@ export const getVendorManifestByOid = (oid: string): IVendorManifest | undefined
                 _id: { $oid: typeNameOid },
                 TypeName: typeName,
                 RandomSeedType: manifest.randomSeedType,
-                cycleDuration: unixTimesInMs.hour
+                cycleDuration: getCycleDuration(manifest)
             });
         }
     }
-- 
2.47.2


From 628ba9c55cce5721c8bb193f3d93df39c20e98bd Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Fri, 16 May 2025 10:58:21 +0200
Subject: [PATCH 2/2] actually nah this is fine

---
 src/services/serversideVendorsService.ts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/services/serversideVendorsService.ts b/src/services/serversideVendorsService.ts
index 81aacd9e..c9a29b64 100644
--- a/src/services/serversideVendorsService.ts
+++ b/src/services/serversideVendorsService.ts
@@ -81,12 +81,6 @@ const generatableVendors: IGeneratableVendorInfo[] = [
         WeaponUpgradeValueAttenuationExponent: 2.25,
         cycleOffset: 1744934400_000,
         cycleDuration: 4 * unixTimesInMs.day
-    },
-    {
-        _id: { $oid: "61ba123467e5d37975aeeb03" }, // The game expects this specific oid
-        TypeName: "/Lotus/Types/Game/VendorManifests/Hubs/GuildAdvertisementVendorManifest",
-        RandomSeedType: "VRST_FLAVOUR_TEXT",
-        cycleDuration: unixTimesInMs.week
     }
     // {
     //     _id: { $oid: "5dbb4c41e966f7886c3ce939" },
-- 
2.47.2