From cbf6f3ece736a43d86f272636787c5fc45dff5d3 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sat, 26 Apr 2025 20:27:37 +0200 Subject: [PATCH 1/2] fix: give rewards for completing a capture mission --- src/services/missionInventoryUpdateService.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index 32f6b35e..bd64f265 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -69,8 +69,10 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[] return rotations; } + const missionIndex = ExportRegions[rewardInfo.node].missionIndex; + // For Rescue missions - if (rewardInfo.node in ExportRegions && ExportRegions[rewardInfo.node].missionIndex == 3 && rewardInfo.rewardTier) { + if (rewardInfo.node in ExportRegions && missionIndex == 3 && rewardInfo.rewardTier) { return [rewardInfo.rewardTier]; } @@ -80,6 +82,11 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[] // - Aborting a railjack mission (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1741) // - Completing only 1 zone of (E)SO (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1823) + // Successful completion of a capture mission should always give a rot A reward, although it has the same rewardInfo as completing only 1 zone of (E)SO + if (missionIndex == 5) { + return [0]; + } + const rotationPattern = tierOverride === undefined ? [0, 0, 1, 2] // A, A, B, C -- 2.47.2 From e9a27998053e3626924710976ed5d06db485d244 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sat, 26 Apr 2025 20:53:26 +0200 Subject: [PATCH 2/2] blacklist approach --- src/services/missionInventoryUpdateService.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index bd64f265..bf013100 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -78,12 +78,10 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[] const rotationCount = rewardInfo.rewardQualifications?.length || 0; - // Empty or absent rewardQualifications should not give rewards: - // - Aborting a railjack mission (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1741) + // Empty or absent rewardQualifications should not give rewards when: // - Completing only 1 zone of (E)SO (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1823) - - // Successful completion of a capture mission should always give a rot A reward, although it has the same rewardInfo as completing only 1 zone of (E)SO - if (missionIndex == 5) { + // - Aborting a railjack mission (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1741) + if (rotationCount == 0 && missionIndex != 30 && missionIndex != 32) { return [0]; } -- 2.47.2