OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 41 Pull Requests 2 Actions Packages Projects Releases Activity

fix: additional checks in bounty rewards #1626

Merged
Sainan merged 1 commits from AMelonInsideLemon/SpaceNinjaServer:check-locationTag into main 2025-04-15 06:10:26 -07:00
Conversation 6 Commits 1 Files Changed 1 +18 -13
1 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/services/missionInventoryUpdateService.ts
View File

@ -922,7 +922,7 @@ function getRandomMissionDrops(RewardInfo: IRewardInfo, tierOverride: number | u
if (syndicateEntry.Tag === "EntratiSyndicate") { if (syndicateEntry.Tag === "EntratiSyndicate") {
const vault = syndicateEntry.Jobs.find(j => j.locationTag === locationTag); const vault = syndicateEntry.Jobs.find(j => j.locationTag === locationTag);
if (vault) job = vault; if (vault && locationTag) job = vault;
// if ( // if (
// [ // [
// "DeimosRuinsExterminateBounty", // "DeimosRuinsExterminateBounty",
@ -997,12 +997,14 @@ function getRandomMissionDrops(RewardInfo: IRewardInfo, tierOverride: number | u
(RewardInfo.JobStage === job.xpAmounts.length - 1 || job.isVault) && (RewardInfo.JobStage === job.xpAmounts.length - 1 || job.isVault) &&
!isEndlessJob !isEndlessJob
) { ) {
if (ExportRewards[job.rewards]) {
rewardManifests.push(job.rewards); rewardManifests.push(job.rewards);
Sainan commented 2025-04-14 11:47:36 -07:00
Review
Copy Link

Sorry, this line just confuses the fuck out of me. Why are you doing rewardManifests.push(job.rewards); when just a few lines earlier you have rewardManifests = [job.rewards]; ? Surely this is not intentional?

Sorry, this line just confuses the fuck out of me. Why are you doing `rewardManifests.push(job.rewards);` when just a few lines earlier you have `rewardManifests = [job.rewards];` ? Surely this is not intentional?
AMelonInsideLemon commented 2025-04-15 02:27:36 -07:00
Review
Copy Link

When player doesn't fail any bonus objective Q stays true, and if this is last JobStage then we should give additional reward for that JobStage. That why there is push

When player doesn't fail any bonus objective `Q` stays true, and if this is last `JobStage` then we should give `additional` reward for that `JobStage`. That why there is push
rotations.push(ExportRewards[job.rewards].length - 1); rotations.push(ExportRewards[job.rewards].length - 1);
} }
} }
} }
} }
}
} else if (RewardInfo.challengeMissionId) { } else if (RewardInfo.challengeMissionId) {
const rewardTables: Record<string, string[]> = { const rewardTables: Record<string, string[]> = {
EntratiLabSyndicate: [ EntratiLabSyndicate: [
@ -1053,9 +1055,12 @@ function getRandomMissionDrops(RewardInfo: IRewardInfo, tierOverride: number | u
if (rewardManifests.length != 0) { if (rewardManifests.length != 0) {
logger.debug(`generating random mission rewards`, { rewardManifests, rotations }); logger.debug(`generating random mission rewards`, { rewardManifests, rotations });
} }
rewardManifests rewardManifests.forEach(name => {
.map(name => ExportRewards[name]) const table = ExportRewards[name];
.forEach(table => { if (!table) {
logger.error(`unknown droptable: ${name}`);
return;
}
for (const rotation of rotations) { for (const rotation of rotations) {
const rotationRewards = table[rotation]; const rotationRewards = table[rotation];
const drop = getRandomRewardByChance(rotationRewards); const drop = getRandomRewardByChance(rotationRewards);