From 2d6c078eed4b535c00389a93c619243d29f55c6b Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Wed, 9 Apr 2025 23:19:56 +0200 Subject: [PATCH 1/3] fix: set deathmark message title to the boss' name --- src/services/missionInventoryUpdateService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index ab5bdcdb..f452c6a5 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -368,7 +368,7 @@ export const addMissionInventoryUpdates = async ( // It's a new death mark; we have to say the line. await createMessage(inventory.accountOwnerId, [ { - sub: "/Lotus/Language/G1Quests/DeathMarkTitle", + sub: deathMark, sndr: "/Lotus/Language/G1Quests/DeathMarkSender", msg: "/Lotus/Language/G1Quests/DeathMarkMessage", icon: "/Lotus/Interface/Icons/Npcs/Stalker_d.png", -- 2.47.2 From de30ac4f332b12ad7974653991ed113b792b8de1 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Wed, 9 Apr 2025 23:21:30 +0200 Subject: [PATCH 2/3] remove lambda --- src/services/missionInventoryUpdateService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index f452c6a5..d6457f96 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -364,7 +364,7 @@ export const addMissionInventoryUpdates = async ( } case "DeathMarks": { for (const deathMark of value) { - if (!inventory.DeathMarks.find(x => x == deathMark)) { + if (inventory.DeathMarks.indexOf(deathMark) == -1) { // It's a new death mark; we have to say the line. await createMessage(inventory.accountOwnerId, [ { -- 2.47.2 From 83e42c408e2fc438323db47c1b5b5bbb52bc8ce5 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Wed, 9 Apr 2025 23:21:58 +0200 Subject: [PATCH 3/3] improve variable name --- src/services/missionInventoryUpdateService.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index d6457f96..5494d232 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -363,12 +363,12 @@ export const addMissionInventoryUpdates = async ( break; } case "DeathMarks": { - for (const deathMark of value) { - if (inventory.DeathMarks.indexOf(deathMark) == -1) { + for (const bossName of value) { + if (inventory.DeathMarks.indexOf(bossName) == -1) { // It's a new death mark; we have to say the line. await createMessage(inventory.accountOwnerId, [ { - sub: deathMark, + sub: bossName, sndr: "/Lotus/Language/G1Quests/DeathMarkSender", msg: "/Lotus/Language/G1Quests/DeathMarkMessage", icon: "/Lotus/Interface/Icons/Npcs/Stalker_d.png", -- 2.47.2