From 5fd9c784b82d5cc39b5b15add84d6aec76204f9c Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sun, 6 Apr 2025 14:57:57 +0200 Subject: [PATCH 1/2] fix: handle client providing an invalid loadout id at EOM upload --- src/services/missionInventoryUpdateService.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index 60fda2d4..f4dfc43a 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -441,7 +441,10 @@ export const addMissionInventoryUpdates = async ( _id: new Types.ObjectId(ItemId.$oid), ...loadoutConfigItemIdRemoved }; - loadout.NORMAL.id(loadoutId)!.overwrite(loadoutConfigDatabase); + const dbConfig = loadout.NORMAL.id(loadoutId); + if (dbConfig) { + dbConfig.overwrite(loadoutConfigDatabase); + } } await loadout.save(); } -- 2.47.2 From b0caaae5d483415fabf43ef46741e0023ecee9e1 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sun, 6 Apr 2025 15:00:08 +0200 Subject: [PATCH 2/2] raise a warning --- src/services/missionInventoryUpdateService.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index f4dfc43a..0f7b5e55 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -444,6 +444,8 @@ export const addMissionInventoryUpdates = async ( const dbConfig = loadout.NORMAL.id(loadoutId); if (dbConfig) { dbConfig.overwrite(loadoutConfigDatabase); + } else { + logger.warn(`couldn't update loadout because there's no config with id ${loadoutId}`); } } await loadout.save(); -- 2.47.2