OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 41 Pull Requests 2 Actions Packages Projects Releases Activity

chore: remove needless query when sending clan invite #1434

Merged
Sainan merged 2 commits from clan-invite-try into main 2025-04-03 06:17:38 -07:00
Conversation 0 Commits 2 Files Changed 1 +8 -12
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/controllers/api/addToGuildController.ts
View File

@ -35,21 +35,17 @@ export const addToGuildController: RequestHandler = async (req, res) => {
res.status(400).json("Invalid permission"); res.status(400).json("Invalid permission");
} }
if ( try {
await GuildMember.exists({
accountId: account._id,
guildId: payload.GuildId.$oid
})
) {
res.status(400).json("User already invited to clan");
return;
}
await GuildMember.insertOne({ await GuildMember.insertOne({
accountId: account._id, accountId: account._id,
guildId: payload.GuildId.$oid, guildId: payload.GuildId.$oid,
status: 2 // outgoing invite status: 2 // outgoing invite
}); });
} catch (e) {
logger.debug(`guild invite failed due to ${String(e)}`);
res.status(400).json("User already invited to clan");
return;
}
const senderInventory = await getInventory(senderAccount._id.toString(), "ActiveAvatarImageType"); const senderInventory = await getInventory(senderAccount._id.toString(), "ActiveAvatarImageType");
await createMessage(account._id, [ await createMessage(account._id, [
@ -92,7 +88,7 @@ export const addToGuildController: RequestHandler = async (req, res) => {
RequestExpiry: new Date(Date.now() + 14 * 86400 * 1000) // TOVERIFY: I can't find any good information about this with regards to live, but 2 weeks seem reasonable. RequestExpiry: new Date(Date.now() + 14 * 86400 * 1000) // TOVERIFY: I can't find any good information about this with regards to live, but 2 weeks seem reasonable.
}); });
} catch (e) { } catch (e) {
// Assuming this is "E11000 duplicate key error" due to the guildId-accountId unique index. logger.debug(`alliance invite failed due to ${String(e)}`);
res.status(400).send("Already requested"); res.status(400).send("Already requested");
} }
res.end(); res.end();