basic session management completed #11

Merged
AKCore merged 9 commits from main into main 2023-06-03 19:24:57 -07:00
2 changed files with 24 additions and 24 deletions
Showing only changes of commit a809981179 - Show all commits

View File

@ -56,7 +56,8 @@ function getSession(sessionIdOrRequest: string | FindSessionRequest): any[] {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
]; ];
} }
return []; return [];
} else { }
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const request = sessionIdOrRequest as FindSessionRequest; const request = sessionIdOrRequest as FindSessionRequest;
const matchingSessions = sessions.filter(session => { const matchingSessions = sessions.filter(session => {
for (const key in request) { for (const key in request) {
@ -72,7 +73,6 @@ function getSession(sessionIdOrRequest: string | FindSessionRequest): any[] {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
id: session.sessionId id: session.sessionId
})); }));
} }
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
function getSessionByCreatorID(creatorId: string): Session | undefined { function getSessionByCreatorID(creatorId: string): Session | undefined {
return sessions.find(session => session.creatorId === creatorId); return sessions.find(session => session.creatorId === creatorId);

AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.