basic session management completed #11

Merged
AKCore merged 9 commits from main into main 2023-06-03 19:24:57 -07:00
2 changed files with 24 additions and 24 deletions
Showing only changes of commit a809981179 - Show all commits

View File

@ -56,22 +56,22 @@ function getSession(sessionIdOrRequest: string | FindSessionRequest): any[] {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
];
}
return [];
} else {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const request = sessionIdOrRequest as FindSessionRequest;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const matchingSessions = sessions.filter(session => {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
for (const key in request) {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
if (key !== "eloRating" && key !== "queryId" && request[key] !== session[key as keyof Session]) {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return false;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
console.log("Found Matching Sessions:", matchingSessions);
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return true;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
});
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return matchingSessions.map(session => ({
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
createdBy: session.creatorId,
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
id: session.sessionId
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}));
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const request = sessionIdOrRequest as FindSessionRequest;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const matchingSessions = sessions.filter(session => {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
for (const key in request) {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
if (key !== "eloRating" && key !== "queryId" && request[key] !== session[key as keyof Session]) {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return false;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
console.log("Found Matching Sessions:", matchingSessions);
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return true;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
});
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return matchingSessions.map(session => ({
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
createdBy: session.creatorId,
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
id: session.sessionId
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}));
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
function getSessionByCreatorID(creatorId: string): Session | undefined {
@ -101,14 +101,14 @@ function getNewSessionID(): string {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
function updateSession(sessionId: string, sessionData: string): boolean {
const session = sessions.find(session => session.sessionId === sessionId);
if (!session) return false;
try {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const updatedData = JSON.parse(sessionData);
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
Object.assign(session, updatedData);
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return true;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
} catch (error) {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
console.error("Invalid JSON string for session update.");
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return false;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
try {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
const updatedData = JSON.parse(sessionData);
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
Object.assign(session, updatedData);
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return true;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
} catch (error) {
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
console.error("Invalid JSON string for session update.");
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
return false;
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
}
function deleteSession(sessionId: string): boolean {

AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 17:59:47 -07:00 (Migrated from github.com)
Review

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:00:43 -07:00 (Migrated from github.com)
Review

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:01:52 -07:00 (Migrated from github.com)
Review

redundant else

redundant else
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AngeloTadeucci commented 2023-06-03 18:03:43 -07:00 (Migrated from github.com)
Review

invert if

invert if
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AKCore commented 2023-06-03 18:12:59 -07:00 (Migrated from github.com)
Review

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci commented 2023-06-03 18:14:44 -07:00 (Migrated from github.com)
Review

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

View File

@ -24,4 +24,4 @@ export interface Session {
freePublic: number;
freePrivate: number;
fullReset: number;
}
}