basic session management completed #11
@ -1,8 +1,7 @@
|
||||
import { RequestHandler } from "express";
|
||||
import { deleteSession } from '@/src/managers/sessionManager';
|
||||
import { deleteSession } from "@/src/managers/sessionManager";
|
||||
|
||||
const deleteSessionController: RequestHandler = (_req, res) => {
|
||||
|
||||
//res.json({ sessionId: { $oid: "64768f104722f795300c9fc0" }, rewardSeed: 5867309943877621023 });
|
||||
deleteSession(_req.query.sessionId as string);
|
||||
res.sendStatus(200);
|
||||
|
||||
@ -1,42 +1,28 @@
|
||||
|
|
||||
import { RequestHandler } from "express";
|
||||
import { getSession } from '@/src/managers/sessionManager';
|
||||
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
import { getSession } from "@/src/managers/sessionManager";
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
|
||||
const findSessionsController: RequestHandler = (_req, res) => {
|
||||
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
console.log("FindSession Request:", JSON.parse(_req.body));
|
||||
let r = JSON.parse(_req.body);
|
||||
if(r != undefined)
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
{
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
if (r != undefined) {
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
console.log("Found ID");
|
||||
let s = getSession(r.id);
|
||||
|
||||
if(s)
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
res.json({"queryId":r.queryId,"Sessions":s});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
res.json({});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
}
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else if(r != undefined)
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
{
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
if (s) res.json({ queryId: r.queryId, Sessions: s });
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else res.json({});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
} else if (r != undefined) {
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
console.log("Found OriginalSessionID");
|
||||
|
||||
let s = getSession(r.originalSessionId);
|
||||
if(s)
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
res.json({"queryId":r.queryId,"Sessions":[s]});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
res.json({});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
}
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
{
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
if (s) res.json({ queryId: r.queryId, Sessions: [s] });
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else res.json({});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
} else {
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
console.log("Found SessionRequest");
|
||||
|
||||
let s = getSession(_req.body);
|
||||
if(s)
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
res.json({"queryId":r.queryId,"Sessions":[s]});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
res.json({});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
if (s) res.json({ queryId: r.queryId, Sessions: [s] });
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
else res.json({});
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
}
|
||||
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
||||
};
|
||||
|
||||
export { findSessionsController };
|
||||
|
||||
|
pls add curly braces everywhere pls add curly braces everywhere
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
Fixed this code Fixed this code
|
||||
@ -1,5 +1,5 @@
|
||||
import { RequestHandler } from "express";
|
||||
import { createNewSession } from '@/src/managers/sessionManager';
|
||||
import { createNewSession } from "@/src/managers/sessionManager";
|
||||
|
||||
const hostSessionController: RequestHandler = (_req, res) => {
|
||||
console.log("HostSession Request:", JSON.parse(_req.body));
|
||||
|
||||
@ -1,12 +1,11 @@
|
||||
import { RequestHandler } from "express";
|
||||
import { getSessionByID } from '@/src/managers/sessionManager';
|
||||
import { getSessionByID } from "@/src/managers/sessionManager";
|
||||
|
||||
const joinSessionController: RequestHandler = (_req, res) => {
|
||||
|
||||
console.log("JoinSession Request:", JSON.parse(_req.body));
|
||||
let r = JSON.parse(_req.body);
|
||||
let s = getSessionByID(r.sessionIds[0])
|
||||
res.json({"rewardSeed":s?.rewardSeed,"sessionId":{"$oid":s?.sessionId}});
|
||||
let s = getSessionByID(r.sessionIds[0]);
|
||||
res.json({ rewardSeed: s?.rewardSeed, sessionId: { $oid: s?.sessionId } });
|
||||
};
|
||||
|
||||
export { joinSessionController };
|
||||
@ -1,13 +1,13 @@
|
||||
import { RequestHandler } from "express";
|
||||
import { updateSession } from '@/src/managers/sessionManager';
|
||||
import { updateSession } from "@/src/managers/sessionManager";
|
||||
|
||||
const updateSessionGetController: RequestHandler = (_req, res) => {
|
||||
res.json({});
|
||||
};
|
||||
const updateSessionPostController: RequestHandler = (_req, res) => {
|
||||
console.log("UpdateSessions POST Request:", JSON.parse(_req.body));
|
||||
console.log("ReqID:",_req.query.sessionId as string)
|
||||
updateSession(_req.query.sessionId as string, _req.body)
|
||||
console.log("ReqID:", _req.query.sessionId as string);
|
||||
updateSession(_req.query.sessionId as string, _req.body);
|
||||
res.json({});
|
||||
};
|
||||
export { updateSessionGetController, updateSessionPostController };
|
||||
|
||||
@ -44,18 +44,18 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
difficulty: sessionData.difficulty || 0,
|
||||
hasStarted: sessionData.hasStarted || false,
|
||||
enableVoice: sessionData.enableVoice || true,
|
||||
matchType: sessionData.matchType || 'NORMAL',
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
matchType: sessionData.matchType || "NORMAL",
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
maps: sessionData.maps || [],
|
||||
originalSessionId: sessionData.originalSessionId || '',
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
customSettings: sessionData.customSettings || '',
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
originalSessionId: sessionData.originalSessionId || "",
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
customSettings: sessionData.customSettings || "",
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
rewardSeed: sessionData.rewardSeed || -1,
|
||||
guildId: sessionData.guildId || '',
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
guildId: sessionData.guildId || "",
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
buildId: sessionData.buildId || 4920386201513015989,
|
||||
platform: sessionData.platform || 0,
|
||||
xplatform: sessionData.xplatform || true,
|
||||
freePublic: sessionData.freePublic || 3,
|
||||
freePrivate: sessionData.freePrivate || 0,
|
||||
fullReset:0,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
fullReset: 0
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
};
|
||||
sessions.push(newSession);
|
||||
return newSession;
|
||||
@ -69,21 +69,20 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
return sessions.find(session => session.sessionId === sessionId);
|
||||
}
|
||||
|
||||
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
interface FindSessionRequest {
|
||||
[key: string]: any;
|
||||
}
|
||||
|
||||
function getSession(sessionIdOrRequest: string | FindSessionRequest): any[] {
|
||||
if (typeof sessionIdOrRequest === 'string') {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
if (typeof sessionIdOrRequest === "string") {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
const session = sessions.find(session => session.sessionId === sessionIdOrRequest);
|
||||
if (session) {
|
||||
console.log("Found Sessions:",session)
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
console.log("Found Sessions:", session);
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
return [
|
||||
{
|
||||
createdBy: session.creatorId,
|
||||
id: session.sessionId,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
},
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
id: session.sessionId
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
}
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
];
|
||||
}
|
||||
return [];
|
||||
@ -91,16 +90,16 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
const request = sessionIdOrRequest as FindSessionRequest;
|
||||
const matchingSessions = sessions.filter(session => {
|
||||
for (const key in request) {
|
||||
if (key !== 'eloRating' && key !== 'queryId' && request[key] !== session[key as keyof Session]) {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
if (key !== "eloRating" && key !== "queryId" && request[key] !== session[key as keyof Session]) {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
could remove this for loop and just use some type of UUID could remove this for loop and just use some type of UUID
uuid package is really good, I can help to set it up. uuid package is really good, I can help to set it up.
|
||||
console.log("Found Matching Sessions:",matchingSessions)
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
console.log("Found Matching Sessions:", matchingSessions);
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
return true;
|
||||
});
|
||||
return matchingSessions.map(session => ({
|
||||
createdBy: session.creatorId,
|
||||
id: session.sessionId,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
id: session.sessionId
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
}));
|
||||
}
|
||||
}
|
||||
@ -110,12 +109,12 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
}
|
||||
|
||||
function getNewSessionID(): string {
|
||||
const characters = '0123456789abcdef';
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
const characters = "0123456789abcdef";
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
const maxAttempts = 100;
|
||||
let sessionId = '';
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
let sessionId = "";
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
|
||||
for (let attempt = 0; attempt < maxAttempts; attempt++) {
|
||||
sessionId = '64';
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
sessionId = "64";
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
for (let i = 0; i < 22; i++) {
|
||||
const randomIndex = Math.floor(Math.random() * characters.length);
|
||||
sessionId += characters[randomIndex];
|
||||
@ -126,7 +125,7 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
}
|
||||
}
|
||||
|
||||
throw new Error('Failed to generate a unique session ID');
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
throw new Error("Failed to generate a unique session ID");
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
}
|
||||
|
||||
function updateSession(sessionId: string, sessionData: string): boolean {
|
||||
@ -137,7 +136,7 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
Object.assign(session, updatedData);
|
||||
return true;
|
||||
} catch (error) {
|
||||
console.error('Invalid JSON string for session update.');
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
console.error("Invalid JSON string for session update.");
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
return false;
|
||||
}
|
||||
}
|
||||
@ -153,5 +152,13 @@ interface Session {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
return false;
|
||||
}
|
||||
|
||||
export { createNewSession, getAllSessions, getSessionByID, getSessionByCreatorID, getNewSessionID, updateSession, deleteSession, getSession };
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
export {
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
createNewSession,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
getAllSessions,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
getSessionByID,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
getSessionByCreatorID,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
getNewSessionID,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
updateSession,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
deleteSession,
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
getSession
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
};
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
|
||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
||||
pls add curly braces everywhere
pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return
useless case, already handled above. also would suggest removing the else and using a return
Fixed this code
Fixed this code