basic session management completed #11
@ -4,13 +4,13 @@ import { getSession } from "@/src/managers/sessionManager";
|
|||||||
|
|
|||||||
const findSessionsController: RequestHandler = (_req, res) => {
|
const findSessionsController: RequestHandler = (_req, res) => {
|
||||||
console.log("FindSession Request:", JSON.parse(_req.body));
|
console.log("FindSession Request:", JSON.parse(_req.body));
|
||||||
let r = JSON.parse(_req.body);
|
let r = JSON.parse(_req.body);
|
||||||
if (r != undefined) {
|
if (r.id != undefined) {
|
||||||
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
|||||||
console.log("Found ID");
|
console.log("Found ID");
|
||||||
let s = getSession(r.id);
|
let s = getSession(r.id);
|
||||||
|
|
||||||
if (s) res.json({ queryId: r.queryId, Sessions: s });
|
if (s) res.json({ queryId: r.queryId, Sessions: s });
|
||||||
else res.json({});
|
else res.json({});
|
||||||
} else if (r != undefined) {
|
} else if (r.originalSessionId != undefined) {
|
||||||
|
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
|
|||||||
console.log("Found OriginalSessionID");
|
console.log("Found OriginalSessionID");
|
||||||
|
|
||||||
let s = getSession(r.originalSessionId);
|
let s = getSession(r.originalSessionId);
|
||||||
|
|||||||
|
pls add curly braces everywhere pls add curly braces everywhere
pls add curly braces everywhere pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
useless case, already handled above. also would suggest removing the else and using a return useless case, already handled above. also would suggest removing the else and using a return
Fixed this code Fixed this code
Fixed this code Fixed this code
|
|||||||
@ -1,7 +1,7 @@
|
|||||||
import { RequestHandler } from "express";
|
import { RequestHandler } from "express";
|
||||||
|
|
||||||
const getNewRewardSeedController: RequestHandler = (_req, res) => {
|
const getNewRewardSeedController: RequestHandler = (_req, res) => {
|
||||||
res.json({ rewardSeed: 1111111111 });
|
res.json({ rewardSeed: generateRewardSeed() });
|
||||||
};
|
};
|
||||||
|
|
||||||
function generateRewardSeed(): number {
|
function generateRewardSeed(): number {
|
||||||
|
|||||||
@ -1,30 +1,4 @@
|
|||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
interface Session {
|
import { Session, FindSessionRequest } from "@/src/types/session";
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
sessionId: string;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
creatorId: string;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
maxPlayers: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
minPlayers: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
privateSlots: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
scoreLimit: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
timeLimit: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
gameModeId: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
eloRating: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
regionId: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
difficulty: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
hasStarted: boolean;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
enableVoice: boolean;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
matchType: string;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
maps: string[];
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
originalSessionId: string;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
customSettings: string;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
rewardSeed: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
guildId: string;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
buildId: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
platform: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
xplatform: boolean;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
freePublic: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
freePrivate: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
fullReset: number;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
}
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
|
|
||||||
const sessions: Session[] = [];
|
const sessions: Session[] = [];
|
||||||
|
|
||||||
@ -69,10 +43,6 @@ function getSessionByID(sessionId: string): Session | undefined {
|
|||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
return sessions.find(session => session.sessionId === sessionId);
|
return sessions.find(session => session.sessionId === sessionId);
|
||||||
}
|
}
|
||||||
|
|
||||||
interface FindSessionRequest {
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
[key: string]: any;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
}
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
function getSession(sessionIdOrRequest: string | FindSessionRequest): any[] {
|
function getSession(sessionIdOrRequest: string | FindSessionRequest): any[] {
|
||||||
if (typeof sessionIdOrRequest === "string") {
|
if (typeof sessionIdOrRequest === "string") {
|
||||||
const session = sessions.find(session => session.sessionId === sessionIdOrRequest);
|
const session = sessions.find(session => session.sessionId === sessionIdOrRequest);
|
||||||
@ -130,7 +100,7 @@ function getNewSessionID(): string {
|
|||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
|
|
||||||
function updateSession(sessionId: string, sessionData: string): boolean {
|
function updateSession(sessionId: string, sessionData: string): boolean {
|
||||||
const session = sessions.find(session => session.sessionId === sessionId);
|
const session = sessions.find(session => session.sessionId === sessionId);
|
||||||
if (session) {
|
if (!session) return false;
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
try {
|
try {
|
||||||
const updatedData = JSON.parse(sessionData);
|
const updatedData = JSON.parse(sessionData);
|
||||||
Object.assign(session, updatedData);
|
Object.assign(session, updatedData);
|
||||||
@ -140,8 +110,6 @@ function updateSession(sessionId: string, sessionData: string): boolean {
|
|||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
return false;
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
}
|
|
||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
|
|
||||||
function deleteSession(sessionId: string): boolean {
|
function deleteSession(sessionId: string): boolean {
|
||||||
const index = sessions.findIndex(session => session.sessionId === sessionId);
|
const index = sessions.findIndex(session => session.sessionId === sessionId);
|
||||||
|
|||||||
|
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
move interface to another file like /types/session.ts move interface to another file like /types/session.ts
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
this is basically an 'any' type, could move it to another file an call it "LooseObject" this is basically an 'any' type, could move it to another file an call it "LooseObject"
redundant else redundant else
redundant else redundant else
invert if invert if
invert if invert if
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
i mean only the keyword is redundant. since you are returning in all cases inside the first if block. i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
|
|||||||
27
src/types/session.ts
Normal file
@ -0,0 +1,27 @@
|
|||||||
|
export interface Session {
|
||||||
|
sessionId: string;
|
||||||
|
creatorId: string;
|
||||||
|
maxPlayers: number;
|
||||||
|
minPlayers: number;
|
||||||
|
privateSlots: number;
|
||||||
|
scoreLimit: number;
|
||||||
|
timeLimit: number;
|
||||||
|
gameModeId: number;
|
||||||
|
eloRating: number;
|
||||||
|
regionId: number;
|
||||||
|
difficulty: number;
|
||||||
|
hasStarted: boolean;
|
||||||
|
enableVoice: boolean;
|
||||||
|
matchType: string;
|
||||||
|
maps: string[];
|
||||||
|
originalSessionId: string;
|
||||||
|
customSettings: string;
|
||||||
|
rewardSeed: number;
|
||||||
|
guildId: string;
|
||||||
|
buildId: number;
|
||||||
|
platform: number;
|
||||||
|
xplatform: boolean;
|
||||||
|
freePublic: number;
|
||||||
|
freePrivate: number;
|
||||||
|
fullReset: number;
|
||||||
|
}
|
||||||
pls add curly braces everywhere
pls add curly braces everywhere
useless case, already handled above. also would suggest removing the else and using a return
useless case, already handled above. also would suggest removing the else and using a return
Fixed this code
Fixed this code