OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 45 Pull Requests Actions Packages Projects Releases Activity

chore: handle motorcycle in addItems #970

Merged
Sainan merged 1 commits from add-mc into main 2025-02-19 13:53:22 -08:00
Conversation 1 Commits 1 Files Changed 1 +19
Sainan commented 2025-02-19 13:47:09 -08:00
Owner
Copy Link

Closes #968

Closes #968
Sainan added 1 commit 2025-02-19 13:47:10 -08:00
chore: handle motorcycle in addItems
All checks were successful
Build / build (18) (pull_request) Successful in 34s
Details
Build / build (22) (pull_request) Successful in 32s
Details
Build / build (20) (pull_request) Successful in 57s
Details
Build / build (18) (push) Successful in 36s
Details
Build / build (22) (push) Successful in 55s
Details
Build / build (20) (push) Successful in 1m8s
Details
0a041af6d6
OrdisPrime reviewed 2025-02-19 13:50:19 -08:00
src/services/inventoryService.ts
@ -856,0 +868,4 @@
}
const index = inventory.Motorcycles.push({ ItemType: typeName }) - 1;
inventoryChanges.Motorcycles ??= [];
(inventoryChanges.Motorcycles as object[]).push(inventory.Motorcycles[index].toJSON());
OrdisPrime commented 2025-02-19 13:50:19 -08:00
Owner
Copy Link

i would like not to use as object[] defeats the purpose of type checking

i would like not to use as object[] defeats the purpose of type checking
Sainan commented 2025-02-19 13:51:47 -08:00
Author
Owner
Copy Link

It really doesn't matter

It really doesn't matter
Sainan merged commit dee302c996 into main 2025-02-19 13:53:22 -08:00
Sainan deleted branch add-mc 2025-02-19 13:53:22 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#970
No description provided.
Delete Branch "add-mc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?