WIP: feat(webui): translations support #903

Closed

AMelonInsideLemon wants to merge 5 commits from AMelonInsideLemon:webui-lang into main

pull from: AMelonInsideLemon:webui-lang

merge into: OpenWF:main

Conversation 3 Commits 5 Files Changed 23 +2463 -188

AMelonInsideLemon commented 2025-02-04 22:19:04 -08:00

Contributor

Copy Link

Closes #900

Closes #900

AMelonInsideLemon added 1 commit 2025-02-04 22:19:05 -08:00

feat(webui): translations support ... 3a5a43d08e

Closes #900

AMelonInsideLemon added 1 commit 2025-02-04 22:30:26 -08:00

load english as fallback 5ca8af0954

AMelonInsideLemon added 1 commit 2025-02-04 22:37:56 -08:00

don't call unnecessary functions until logged in 9ebff4ee89

Sainan commented 2025-02-05 03:55:21 -08:00

Owner

Copy Link

When I update en.json, how am I supposed to sync it with the target languages?

When I update en.json, how am I supposed to sync it with the target languages?

AMelonInsideLemon added 1 commit 2025-02-05 05:50:02 -08:00

add update-translations script da0183a101

AMelonInsideLemon added 1 commit 2025-02-05 05:57:10 -08:00

lint fix 2c01c06405

AMelonInsideLemon commented 2025-02-05 05:58:54 -08:00

Author

Contributor

Copy Link

Is that okay?

Is that okay?

Sainan commented 2025-02-05 06:29:23 -08:00

Owner

Copy Link

Don't worry about it. I do like that you took the time split the strings from HTML into a different file, and I will probably use this in some form.

Don't worry about it. I do like that you took the time split the strings from HTML into a different file, and I will probably use this in some form.

Sainan changed title from feat(webui): translations support to WIP: feat(webui): translations support 2025-02-05 08:58:17 -08:00

Sainan referenced this pull request 2025-02-05 18:41:24 -08:00

feat(webui): translations #909

Sainan closed this pull request 2025-02-05 18:41:42 -08:00

Sainan referenced this issue from a commit 2025-02-06 07:00:23 -08:00

feat(webui): translations (#909)

All checks were successful

Hide all checks

Build / build (20) (pull_request) Successful in 34s

Details

Build / build (18) (pull_request) Successful in 51s

Details

Build / build (22) (pull_request) Successful in 1m3s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#903

No description provided.