fix: premature week rollover #771

Sainan · 2025-01-11T20:33:14-08:00

Sainan commented

2025-01-11 20:33:14 -08:00

No description provided.

coderabbitai[bot] commented

2025-01-11 20:33:22 -08:00

(Migrated from github.com)

Walkthrough

The pull request introduces a modification to the worldStateController in the src/controllers/dynamic/worldStateController.ts file. Specifically, the change alters the calculation of the week variable by adjusting the number added to the day variable from 4 to 3. This modification impacts how the week number is determined, with the calculation now starting from a slightly different point. The change appears to be related to the week numbering system, potentially affecting how weeks are tracked and how subsequent logic dependent on the week number is processed. The overall structure of the controller remains consistent, with only this specific calculation being updated.

Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## Walkthrough The pull request introduces a modification to the `worldStateController` in the `src/controllers/dynamic/worldStateController.ts` file. Specifically, the change alters the calculation of the `week` variable by adjusting the number added to the `day` variable from 4 to 3. This modification impacts how the week number is determined, with the calculation now starting from a slightly different point. The change appears to be related to the week numbering system, potentially affecting how weeks are tracked and how subsequent logic dependent on the week number is processed. The overall structure of the controller remains consistent, with only this specific calculation being updated.      ## Finishing Touches - [ ]  📝 Generate Docstrings (Beta)   --- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. ([Beta](https://docs.coderabbit.ai/early-access#beta)) - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details>

coderabbitai[bot] (Migrated from github.com) reviewed 2025-01-11 20:34:29 -08:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cd47c8ae2 and 732061f55a.

📒 Files selected for processing (1)

src/controllers/dynamic/worldStateController.ts (1 hunks)

**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 2cd47c8ae2e196363100c81fa3373526a298c9e3 and 732061f55a6d099300893b6615c5d68c957ae794. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `src/controllers/dynamic/worldStateController.ts` (1 hunks) </details> </details>

src/controllers/dynamic/worldStateController.ts

						
				@ -22,3 +22,3 @@

				    const day = Math.trunc(new Date().getTime() / 86400000);

				    const week = Math.trunc((day + 4) / 7); // week begins on mondays

				    const week = Math.trunc((day + 3) / 7); // week begins on mondays

				    const weekStart = week * 604800000;

coderabbitai[bot] (Migrated from github.com) commented

2025-01-11 20:34:28 -08:00

💡 Codebase verification

⚠️ Potential issue

Incorrect week calculation offset will misalign weekly rotations

The change from +4 to +3 in the week calculation is incorrect. Since Unix epoch (Jan 1, 1970) was a Thursday, we need +4 days to align with the next Monday. Using +3 will cause weeks to start on Sundays instead, breaking the intended Monday-based weekly rotations for:

Elite Sanctuary Onslaught seeds
Circuit choices
Calendar Season

Fix by reverting to the original offset:

-    const week = Math.trunc((day + 3) / 7); // week begins on mondays
+    const week = Math.trunc((day + 4) / 7); // week begins on mondays

🔗 Analysis chain

Revert the offset change to maintain Monday-based weeks.

The change from +4 to +3 is incorrect and will cause weeks to start on Sundays instead of Mondays. Here's why:

day counts days since Unix epoch (Jan 1, 1970), which was a Thursday
To align with Monday-based weeks:
- We need 4 days to reach the next Monday (Thu→Fri→Sat→Sun→Mon)
- Therefore, the correct offset is +4, not +3

This change will cause all weekly cycles to shift by one day, affecting:

Elite Sanctuary Onslaught seeds
Circuit choices rotation
Calendar Season rotation

Apply this diff to fix the week calculation:

-    const week = Math.trunc((day + 3) / 7); // week begins on mondays
+    const week = Math.trunc((day + 4) / 7); // week begins on mondays

Let's verify the week calculation:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that weeks start on Mondays with the current offset

# Test 1: Check if Jan 1, 1970 was a Thursday
date -d "@0" "+%A"  # Should output: Thursday

# Test 2: Calculate the number of days needed to reach the next Monday
date -d "@0" "+%u"  # Should output: 4 (Thursday is day 4 in ISO week numbering)

Length of output: 44

_:bulb: Codebase verification_ _:warning: Potential issue_ **Incorrect week calculation offset will misalign weekly rotations** The change from `+4` to `+3` in the week calculation is incorrect. Since Unix epoch (Jan 1, 1970) was a Thursday, we need +4 days to align with the next Monday. Using +3 will cause weeks to start on Sundays instead, breaking the intended Monday-based weekly rotations for: - Elite Sanctuary Onslaught seeds - Circuit choices - Calendar Season Fix by reverting to the original offset: ```diff - const week = Math.trunc((day + 3) / 7); // week begins on mondays + const week = Math.trunc((day + 4) / 7); // week begins on mondays ``` <details> <summary>🔗 Analysis chain</summary> **Revert the offset change to maintain Monday-based weeks.** The change from `+4` to `+3` is incorrect and will cause weeks to start on Sundays instead of Mondays. Here's why: 1. `day` counts days since Unix epoch (Jan 1, 1970), which was a Thursday 2. To align with Monday-based weeks: - We need 4 days to reach the next Monday (Thu→Fri→Sat→Sun→Mon) - Therefore, the correct offset is `+4`, not `+3` This change will cause all weekly cycles to shift by one day, affecting: - Elite Sanctuary Onslaught seeds - Circuit choices rotation - Calendar Season rotation Apply this diff to fix the week calculation: ```diff - const week = Math.trunc((day + 3) / 7); // week begins on mondays + const week = Math.trunc((day + 4) / 7); // week begins on mondays ``` Let's verify the week calculation: </details> <details> <summary>🏁 Scripts executed</summary> The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Verify that weeks start on Mondays with the current offset # Test 1: Check if Jan 1, 1970 was a Thursday date -d "@0" "+%A" # Should output: Thursday # Test 2: Calculate the number of days needed to reach the next Monday date -d "@0" "+%u" # Should output: 4 (Thursday is day 4 in ISO week numbering) ``` Length of output: 44 </details>

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#771