feat: implement aya costs for varzia offers #606

Sainan · 2024-12-22T12:57:52-08:00

Sainan commented

2024-12-22 12:57:52 -08:00

Fixes #555

coderabbitai[bot] commented

2024-12-22 12:57:59 -08:00

(Migrated from github.com)

Warning

Rate limit exceeded

@Sainan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6d3ea67273 and ae4fa79dec.

📒 Files selected for processing (1)

src/services/purchaseService.ts (4 hunks)

Walkthrough

The pull request introduces changes to multiple files related to inventory and purchase systems. In the inventoryModel.ts, a new property PrimeTokens is added to the inventory schema as a Number type. The purchaseService.ts file is updated to include a new case (case 18) for handling purchases from a Prime Vault Trader, which involves checking the source ID against world state traders and processing inventory changes accordingly.

The inventoryTypes.ts file undergoes type modifications, including changing several field types to use MongoDB's native ObjectId and adding a PrimeTokens field to the IInventoryResponse interface. Additionally, the purchaseTypes.ts file is minimally updated with a comment modification to indicate that the SourceId is now applicable for both Source 7 and Source 18.

These changes appear to be part of an implementation for a new purchasing mechanism involving Prime Vault Traders and a new PrimeTokens currency type.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve purchase request for Source 18	✅
Properly handle currency consumption	❓	No clear evidence of Aya consumption in the provided changes.

#582: Adds PrimeTokens property to IInventoryResponse interface.
#586: Modifies IInventoryResponse interface with new optional properties.
#588: Handles inventory credits and introduces infinite credit concepts.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

> [!WARNING] > ## Rate limit exceeded > > @Sainan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait **19 minutes and 9 seconds** before requesting another review. > > <details> > <summary>⌛ How to resolve this issue?</summary> > > After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. > > We recommend that you space out your commits to avoid hitting the rate limit. > > </details> > > > <details> > <summary>🚦 How do rate limits work?</summary> > > CodeRabbit enforces hourly rate limits for each developer per organization. > > Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. > > Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information. > > </details> > > <details> > <summary>📥 Commits</summary> > > Reviewing files that changed from the base of the PR and between 6d3ea67273d31c5307d57b5e55d9ae8e1d657a43 and ae4fa79decf83ba3de7fb3cdc6ce8f36f491f45a. > > </details> > > <details> > <summary>📒 Files selected for processing (1)</summary> > > * `src/services/purchaseService.ts` (4 hunks) > > </details>   ## Walkthrough The pull request introduces changes to multiple files related to inventory and purchase systems. In the `inventoryModel.ts`, a new property `PrimeTokens` is added to the inventory schema as a Number type. The `purchaseService.ts` file is updated to include a new case (case 18) for handling purchases from a Prime Vault Trader, which involves checking the source ID against world state traders and processing inventory changes accordingly. The `inventoryTypes.ts` file undergoes type modifications, including changing several field types to use MongoDB's native ObjectId and adding a `PrimeTokens` field to the `IInventoryResponse` interface. Additionally, the `purchaseTypes.ts` file is minimally updated with a comment modification to indicate that the `SourceId` is now applicable for both Source 7 and Source 18. These changes appear to be part of an implementation for a new purchasing mechanism involving Prime Vault Traders and a new `PrimeTokens` currency type. ## Assessment against linked issues | Objective | Addressed | Explanation | |---------------------------------------------|-----------|---------------------------------------------------------------| | Resolve purchase request for Source 18 | ✅ | | | Properly handle currency consumption | ❓ | No clear evidence of Aya consumption in the provided changes. | ## Possibly related PRs - **#582**: Adds `PrimeTokens` property to `IInventoryResponse` interface. - **#586**: Modifies `IInventoryResponse` interface with new optional properties. - **#588**: Handles inventory credits and introduces infinite credit concepts.      --- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. ([Beta](https://docs.coderabbit.ai/early-access#beta)) - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details>

coderabbitai[bot] (Migrated from github.com) reviewed 2024-12-22 12:59:43 -08:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a31ff7b5c and 5bd32f8387.

📒 Files selected for processing (4)

src/models/inventoryModels/inventoryModel.ts (1 hunks)
src/services/purchaseService.ts (2 hunks)
src/types/inventoryTypes/inventoryTypes.ts (1 hunks)
src/types/purchaseTypes.ts (1 hunks)

🧰 Additional context used

🪛 Biome (1.9.4)

src/services/purchaseService.ts

[error] 92-98: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

🔇 Additional comments (4)

src/services/purchaseService.ts (1)

15-15: **Import statement looks good **

Importing worldState here is necessary for the new prime vault trader functionality.

src/types/purchaseTypes.ts (1)

8-8: **Consistency with new source case **

Updating the comment to reflect that SourceId applies to both Source 7 and 18 aligns well with the new purchase logic for prime vault traders.

src/types/inventoryTypes/inventoryTypes.ts (1)

128-128: **New PrimeTokens field **

Adding “PrimeTokens” to the inventory response is consistent with the newly introduced prime vault trader functionality.

src/models/inventoryModels/inventoryModel.ts (1)

608-609: **Schema update for PrimeTokens **

Defining the “PrimeTokens” field as a Number in the schema aligns with its usage in “purchaseService” and “IInventoryResponse.” This change is coherent with the new feature requirements.

**Actionable comments posted: 1** <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 0a31ff7b5cc3044cb2b819a29c66ebaf51851228 and 5bd32f83872683cccfea5c31d5e567780058374e. </details> <details> <summary>📒 Files selected for processing (4)</summary> * `src/models/inventoryModels/inventoryModel.ts` (1 hunks) * `src/services/purchaseService.ts` (2 hunks) * `src/types/inventoryTypes/inventoryTypes.ts` (1 hunks) * `src/types/purchaseTypes.ts` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🪛 Biome (1.9.4)</summary> <details> <summary>src/services/purchaseService.ts</summary> [error] 92-98: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. (lint/correctness/noSwitchDeclarations) </details> </details> </details> <details> <summary>🔇 Additional comments (4)</summary> <details> <summary>src/services/purchaseService.ts (1)</summary> `15-15`: **Import statement looks good ** Importing worldState here is necessary for the new prime vault trader functionality. </details> <details> <summary>src/types/purchaseTypes.ts (1)</summary> `8-8`: **Consistency with new source case ** Updating the comment to reflect that SourceId applies to both Source 7 and 18 aligns well with the new purchase logic for prime vault traders. </details> <details> <summary>src/types/inventoryTypes/inventoryTypes.ts (1)</summary> `128-128`: **New PrimeTokens field ** Adding “PrimeTokens” to the inventory response is consistent with the newly introduced prime vault trader functionality. </details> <details> <summary>src/models/inventoryModels/inventoryModel.ts (1)</summary> `608-609`: **Schema update for PrimeTokens ** Defining the “PrimeTokens” field as a Number in the schema aligns with its usage in “purchaseService” and “IInventoryResponse.” This change is coherent with the new feature requirements. </details> </details> </details>

src/services/purchaseService.ts

coderabbitai[bot] (Migrated from github.com) commented

2024-12-22 12:59:42 -08:00

🛠️ Refactor suggestion

**Wrap the 'offer' declaration in a block to avoid accidental access from other switch cases **

According to the static analysis hint, declaring variables in a switch case without a block scope can allow inadvertent access from other case branches. Enclose the new logic in a block:

 case 18: {
   if (purchaseRequest.PurchaseParams.SourceId! != worldState.PrimeVaultTraders[0]._id.$oid) {
     throw new Error("invalid request source");
   }
   const offer =
     worldState.PrimeVaultTraders[0].Manifest.find(
       x => x.ItemType == purchaseRequest.PurchaseParams.StoreItem
     ) ??
     worldState.PrimeVaultTraders[0].EvergreenManifest.find(
       x => x.ItemType == purchaseRequest.PurchaseParams.StoreItem
     );
   if (offer) {
     // ...
   }
   break;
 }

Additionally, consider verifying that “PrimePrice” and “RegularPrice” are always defined before use. If “offer.PrimePrice” is undefined, it could lead to runtime errors when subtracting.

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 Biome (1.9.4)

[error] 92-98: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

_:hammer_and_wrench: Refactor suggestion_ **Wrap the 'offer' declaration in a block to avoid accidental access from other switch cases ** According to the static analysis hint, declaring variables in a switch case without a block scope can allow inadvertent access from other case branches. Enclose the new logic in a block: ```diff case 18: { if (purchaseRequest.PurchaseParams.SourceId! != worldState.PrimeVaultTraders[0]._id.$oid) { throw new Error("invalid request source"); } const offer = worldState.PrimeVaultTraders[0].Manifest.find( x => x.ItemType == purchaseRequest.PurchaseParams.StoreItem ) ?? worldState.PrimeVaultTraders[0].EvergreenManifest.find( x => x.ItemType == purchaseRequest.PurchaseParams.StoreItem ); if (offer) { // ... } break; } ``` Additionally, consider verifying that “PrimePrice” and “RegularPrice” are always defined before use. If “offer.PrimePrice” is undefined, it could lead to runtime errors when subtracting. > Committable suggestion skipped: line range outside the PR's diff. <details> <summary>🧰 Tools</summary> <details> <summary>🪛 Biome (1.9.4)</summary> [error] 92-98: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. (lint/correctness/noSwitchDeclarations) </details> </details>

coderabbitai[bot] (Migrated from github.com) reviewed 2024-12-22 13:04:55 -08:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/services/purchaseService.ts (1)

15-15: Consider adding type definitions for worldState JSON

For better type safety and IDE support, consider creating TypeScript interfaces for the worldState JSON structure, especially for the PrimeVaultTraders array and its nested objects.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5bd32f8387 and 6d3ea67273.

📒 Files selected for processing (1)

src/services/purchaseService.ts (2 hunks)

🔇 Additional comments (2)

src/services/purchaseService.ts (2)

92-98: Wrap variable declaration in a block scope

The offer declaration should be wrapped in a block to prevent accidental access from other switch cases.

89-91: Verify trader index assumption

The code only checks against the first Prime Vault Trader (worldState.PrimeVaultTraders[0]). Is this intentional? Consider:

Validating array length before accessing index 0
Implementing logic to handle multiple traders if needed

✅ Verification successful

Let me gather more information about the Prime Vault Traders implementation.

Let me check the worldState interface/type definition to understand the PrimeVaultTraders structure better.

Based on the evidence gathered from the shell scripts:

The fixed response file worldState.json shows PrimeVaultTraders as an array with at least one trader
The code consistently uses index 0 to access the trader's properties (ID, Manifest, EvergreenManifest)
No other implementations or type definitions were found suggesting multiple traders

Accessing first trader is intentional and correct

The current implementation of accessing worldState.PrimeVaultTraders[0] appears to be correct. The fixed response structure shows this is an expected single-trader setup, and the consistent usage throughout the code confirms this design. No array bounds check is necessary as the data structure guarantees at least one trader.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if there can be multiple Prime Vault Traders
rg -A 5 "PrimeVaultTraders" --type json

Length of output: 528

Script:

#!/bin/bash
# Search for Prime Vault Trader related code patterns
ast-grep --pattern 'PrimeVaultTraders'

# Also check for any configuration or constants related to traders count
rg "PrimeVaultTrader" --type ts -B 2 -A 2

Length of output: 1040

Script:

#!/bin/bash
# Look for worldState type definition
ast-grep --pattern 'interface WorldState'

# Also check any type definitions containing PrimeVaultTrader
ast-grep --pattern 'PrimeVaultTrader'

Length of output: 81

**Actionable comments posted: 1** <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>src/services/purchaseService.ts (1)</summary><blockquote> `15-15`: **Consider adding type definitions for worldState JSON** For better type safety and IDE support, consider creating TypeScript interfaces for the worldState JSON structure, especially for the `PrimeVaultTraders` array and its nested objects. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 5bd32f83872683cccfea5c31d5e567780058374e and 6d3ea67273d31c5307d57b5e55d9ae8e1d657a43. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `src/services/purchaseService.ts` (2 hunks) </details> <details> <summary>🔇 Additional comments (2)</summary> <details> <summary>src/services/purchaseService.ts (2)</summary> `92-98`: **Wrap variable declaration in a block scope** The `offer` declaration should be wrapped in a block to prevent accidental access from other switch cases. --- `89-91`: **Verify trader index assumption** The code only checks against the first Prime Vault Trader (`worldState.PrimeVaultTraders[0]`). Is this intentional? Consider: 1. Validating array length before accessing index 0 2. Implementing logic to handle multiple traders if needed <details> <summary>✅ Verification successful</summary> Let me gather more information about the Prime Vault Traders implementation. --- Let me check the worldState interface/type definition to understand the PrimeVaultTraders structure better. --- Based on the evidence gathered from the shell scripts: 1. The fixed response file `worldState.json` shows PrimeVaultTraders as an array with at least one trader 2. The code consistently uses index 0 to access the trader's properties (ID, Manifest, EvergreenManifest) 3. No other implementations or type definitions were found suggesting multiple traders **Accessing first trader is intentional and correct** The current implementation of accessing `worldState.PrimeVaultTraders[0]` appears to be correct. The fixed response structure shows this is an expected single-trader setup, and the consistent usage throughout the code confirms this design. No array bounds check is necessary as the data structure guarantees at least one trader. </details> <details> <summary>🏁 Scripts executed</summary> The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Check if there can be multiple Prime Vault Traders rg -A 5 "PrimeVaultTraders" --type json ``` Length of output: 528 --- Script: ```shell #!/bin/bash # Search for Prime Vault Trader related code patterns ast-grep --pattern 'PrimeVaultTraders' # Also check for any configuration or constants related to traders count rg "PrimeVaultTrader" --type ts -B 2 -A 2 ``` Length of output: 1040 --- Script: ```shell #!/bin/bash # Look for worldState type definition ast-grep --pattern 'interface WorldState' # Also check any type definitions containing PrimeVaultTrader ast-grep --pattern 'PrimeVaultTrader' ``` Length of output: 81 </details> </details> </details> </details>

src/services/purchaseService.ts

coderabbitai[bot] (Migrated from github.com) commented

2024-12-22 13:04:54 -08:00

⚠️ Potential issue

Add validation and error handling

Several improvements needed for robustness:

Validate that offer exists before proceeding
Add null check for PrimePrice when RegularPrice is undefined
Handle purchase quantity (currently ignored)
Consider adding transaction-like behavior for atomic updates

Apply this diff to improve error handling:

 if (offer) {
+    if (!offer.RegularPrice && !offer.PrimePrice) {
+        throw new Error("Invalid offer: missing both RegularPrice and PrimePrice");
+    }
     const inventory = await getInventory(accountId);
     if (offer.RegularPrice) {
         const invItem: IMiscItem = {
             ItemType: "/Lotus/Types/Items/MiscItems/SchismKey",
-            ItemCount: offer.RegularPrice * -1
+            ItemCount: offer.RegularPrice * -1 * purchaseRequest.PurchaseParams.Quantity
         };

         addMiscItems(inventory, [invItem]);

         purchaseResponse.InventoryChanges.MiscItems ??= [];
         (purchaseResponse.InventoryChanges.MiscItems as IMiscItem[]).push(invItem);
     } else {
+        if (!offer.PrimePrice) {
+            throw new Error("Invalid offer: PrimePrice is required when RegularPrice is not set");
+        }
-        inventory.PrimeTokens -= offer.PrimePrice!;
+        inventory.PrimeTokens -= offer.PrimePrice * purchaseRequest.PurchaseParams.Quantity;
+        if (inventory.PrimeTokens < 0) {
+            throw new Error("Insufficient PrimeTokens");
+        }
     }
     await inventory.save();
+} else {
+    throw new Error("Offer not found");
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

            if (offer) {
                if (!offer.RegularPrice && !offer.PrimePrice) {
                    throw new Error("Invalid offer: missing both RegularPrice and PrimePrice");
                }
                const inventory = await getInventory(accountId);
                if (offer.RegularPrice) {
                    const invItem: IMiscItem = {
                        ItemType: "/Lotus/Types/Items/MiscItems/SchismKey",
                        ItemCount: offer.RegularPrice * -1 * purchaseRequest.PurchaseParams.Quantity
                    };

                    addMiscItems(inventory, [invItem]);

                    purchaseResponse.InventoryChanges.MiscItems ??= [];
                    (purchaseResponse.InventoryChanges.MiscItems as IMiscItem[]).push(invItem);
                } else {
                    if (!offer.PrimePrice) {
                        throw new Error("Invalid offer: PrimePrice is required when RegularPrice is not set");
                    }
                    inventory.PrimeTokens -= offer.PrimePrice * purchaseRequest.PurchaseParams.Quantity;
                    if (inventory.PrimeTokens < 0) {
                        throw new Error("Insufficient PrimeTokens");
                    }
                }
                await inventory.save();
            } else {
                throw new Error("Offer not found");
            }

_:warning: Potential issue_ **Add validation and error handling** Several improvements needed for robustness: 1. Validate that `offer` exists before proceeding 2. Add null check for `PrimePrice` when `RegularPrice` is undefined 3. Handle purchase quantity (currently ignored) 4. Consider adding transaction-like behavior for atomic updates Apply this diff to improve error handling: ```diff if (offer) { + if (!offer.RegularPrice && !offer.PrimePrice) { + throw new Error("Invalid offer: missing both RegularPrice and PrimePrice"); + } const inventory = await getInventory(accountId); if (offer.RegularPrice) { const invItem: IMiscItem = { ItemType: "/Lotus/Types/Items/MiscItems/SchismKey", - ItemCount: offer.RegularPrice * -1 + ItemCount: offer.RegularPrice * -1 * purchaseRequest.PurchaseParams.Quantity }; addMiscItems(inventory, [invItem]); purchaseResponse.InventoryChanges.MiscItems ??= []; (purchaseResponse.InventoryChanges.MiscItems as IMiscItem[]).push(invItem); } else { + if (!offer.PrimePrice) { + throw new Error("Invalid offer: PrimePrice is required when RegularPrice is not set"); + } - inventory.PrimeTokens -= offer.PrimePrice!; + inventory.PrimeTokens -= offer.PrimePrice * purchaseRequest.PurchaseParams.Quantity; + if (inventory.PrimeTokens < 0) { + throw new Error("Insufficient PrimeTokens"); + } } await inventory.save(); +} else { + throw new Error("Offer not found"); } ```  <details> <summary>📝 Committable suggestion</summary> > ‼️ **IMPORTANT** > Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements. `````suggestion if (offer) { if (!offer.RegularPrice && !offer.PrimePrice) { throw new Error("Invalid offer: missing both RegularPrice and PrimePrice"); } const inventory = await getInventory(accountId); if (offer.RegularPrice) { const invItem: IMiscItem = { ItemType: "/Lotus/Types/Items/MiscItems/SchismKey", ItemCount: offer.RegularPrice * -1 * purchaseRequest.PurchaseParams.Quantity }; addMiscItems(inventory, [invItem]); purchaseResponse.InventoryChanges.MiscItems ??= []; (purchaseResponse.InventoryChanges.MiscItems as IMiscItem[]).push(invItem); } else { if (!offer.PrimePrice) { throw new Error("Invalid offer: PrimePrice is required when RegularPrice is not set"); } inventory.PrimeTokens -= offer.PrimePrice * purchaseRequest.PurchaseParams.Quantity; if (inventory.PrimeTokens < 0) { throw new Error("Insufficient PrimeTokens"); } } await inventory.save(); } else { throw new Error("Offer not found"); } ````` </details>

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#606