feat: implement socketing of ayatan sculptures #542

Sainan · 2024-10-11T16:36:58-07:00

Sainan commented

2024-10-11 16:36:58 -07:00

closes #541

coderabbitai[bot] commented

2024-10-11 16:37:04 -07:00

(Migrated from github.com)

Walkthrough

The changes in this pull request include updates to various files within the wf-emulator project. The package.json file has been modified to increment the version of the warframe-public-export-plus dependency from ^0.5.1 to ^0.5.2. A new controller, fusionTreasuresController.ts, has been introduced to handle requests related to fusion treasures in an Express application. This controller includes an interface for incoming requests and a function to process these requests, managing the user's inventory and updating it based on the treasures involved. The getItemListsController.ts file has been updated to modify how the uniqueName property is assigned for items, changing the categorization logic. Additionally, a new route has been added in api.ts for the fusionTreasures.php endpoint, linking it to the new controller. Lastly, the addFusionTreasures function in inventoryService.ts has been corrected to improve the accuracy of item index retrieval in the FusionTreasures array.

Assessment against linked issues

Objective	Addressed	Explanation
Implement POST endpoint for `/api/fusionTreasures.php` (541)	✅
Ensure functionality for installing Ayatan Stars (541)	❌	The issue description does not confirm if the installation functionality is fully addressed.

#517: This PR updates the warframe-public-export-plus dependency version from ^0.4.4 to ^0.5.0, which is directly related to the main PR's update from ^0.5.1 to ^0.5.2.
#537: This PR updates the warframe-public-export-plus dependency version from ^0.5.0 to ^0.5.1, which is also directly related to the main PR's update from ^0.5.1 to ^0.5.2.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

## Walkthrough The changes in this pull request include updates to various files within the `wf-emulator` project. The `package.json` file has been modified to increment the version of the `warframe-public-export-plus` dependency from `^0.5.1` to `^0.5.2`. A new controller, `fusionTreasuresController.ts`, has been introduced to handle requests related to fusion treasures in an Express application. This controller includes an interface for incoming requests and a function to process these requests, managing the user's inventory and updating it based on the treasures involved. The `getItemListsController.ts` file has been updated to modify how the `uniqueName` property is assigned for items, changing the categorization logic. Additionally, a new route has been added in `api.ts` for the `fusionTreasures.php` endpoint, linking it to the new controller. Lastly, the `addFusionTreasures` function in `inventoryService.ts` has been corrected to improve the accuracy of item index retrieval in the `FusionTreasures` array. ## Assessment against linked issues | Objective | Addressed | Explanation | |------------------------------------------------------------|-----------|-------------------------------------| | Implement POST endpoint for `/api/fusionTreasures.php` (541) | ✅ | | | Ensure functionality for installing Ayatan Stars (541) | ❌ | The issue description does not confirm if the installation functionality is fully addressed. | ## Possibly related PRs - #517: This PR updates the `warframe-public-export-plus` dependency version from `^0.4.4` to `^0.5.0`, which is directly related to the main PR's update from `^0.5.1` to `^0.5.2`. - #537: This PR updates the `warframe-public-export-plus` dependency version from `^0.5.0` to `^0.5.1`, which is also directly related to the main PR's update from `^0.5.1` to `^0.5.2`.        --- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? <details> <summary>❤️ Share</summary> - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) </details> <details> <summary>🪧 Tips</summary> ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </details>

coderabbitai[bot] (Migrated from github.com) reviewed 2024-10-11 16:42:50 -07:00

coderabbitai[bot] (Migrated from github.com) left a comment

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (3)

src/services/inventoryService.ts (2)
Line range hint 657-670: Improved item matching logic for FusionTreasures

The change in the addFusionTreasures function enhances the accuracy of item matching. By including both ItemType and Sockets in the comparison, it ensures that items with the same type but different socket configurations are treated as distinct. This prevents incorrect merging of items and maintains the integrity of the inventory.

Consider adding a type guard or default value for the Sockets property to handle potential undefined values more explicitly:
-const itemIndex = FusionTreasures.findIndex(i => i.ItemType == ItemType && (i.Sockets || 0) == (Sockets || 0));
+const itemIndex = FusionTreasures.findIndex(i => i.ItemType === ItemType && (i.Sockets ?? 0) === (Sockets ?? 0));
This change uses the nullish coalescing operator (??) for clearer intent and strict equality (===) for consistency with TypeScript best practices.

Line range hint 1-670: General code quality improvements

While reviewing the file, I noticed some areas where we could improve overall code quality and consistency:

Error handling: Consider implementing a more consistent error handling strategy across functions. For example, the upgradeMod function uses try-catch, while others don't.

Type safety: Enhance type safety by using more specific types instead of any or undefined. For instance, in the updateGeneric function, consider creating a specific type for the data parameter.

Async/await consistency: Ensure all async functions are properly handled with try/catch blocks or returned promises are caught at the caller level.

Code duplication: There are several similar functions for adding different types of items (e.g., addMiscItems, addConsumables, addRecipes). Consider creating a generic function to reduce duplication.

Comments and documentation: Add JSDoc comments to functions, especially for complex operations or those with multiple parameters.

Would you like me to provide specific examples for any of these improvements?
src/controllers/api/fusionTreasuresController.ts (1)

39-39: Remove commented-out debugging code.

The commented-out console.log statement can be removed to keep the codebase clean and maintainable.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between de6c1da55d and 5f7e1bc764.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (5)

package.json (1 hunks)
src/controllers/api/fusionTreasuresController.ts (1 hunks)
src/controllers/custom/getItemListsController.ts (1 hunks)
src/routes/api.ts (2 hunks)
src/services/inventoryService.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

package.json

🧰 Additional context used

🔇 Additional comments (4)

src/controllers/custom/getItemListsController.ts (1)

39-39: Verify client compatibility with the new uniqueName structure for resources.

The change from "MiscItems:" + uniqueName to item.productCategory + ":" + uniqueName introduces a more specific categorization for resource items. While this improves item organization, it may impact client-side code that expects the previous "MiscItems:" prefix.

Consider the following:

Ensure that all client implementations are updated to handle the new uniqueName structure.

Add a comment explaining the rationale behind this change for future reference.

If backward compatibility is a concern, consider implementing a version check or providing a migration path for clients.

To verify the impact of this change, run the following script:

This script will help identify any code that might be affected by the change in the uniqueName structure.
src/routes/api.ts (3)
14-14: LGTM: Import statement for fusionTreasuresController

The import statement for fusionTreasuresController is correctly added and follows the existing pattern in the file. The naming convention is consistent with other controller imports.

14-14: Changes align well with PR objectives

The addition of the fusionTreasuresController import and the new route for "/fusionTreasures.php" are well-integrated into the existing codebase. These changes directly address the PR objective of implementing socketing of Ayatan sculptures and appear to resolve the issue described in #541 regarding the installation of Ayatan Stars in Ayatan Treasures.

The modifications follow the established patterns in the file and should not negatively impact other parts of the application. Overall, these changes seem appropriate and focused on solving the specific problem at hand.

Also applies to: 113-113

113-113: LGTM: New route for fusionTreasures.php

The new POST route for "/fusionTreasures.php" is correctly added and handled by the fusionTreasuresController. This addition aligns with the PR objectives to implement socketing of Ayatan sculptures. The route naming and placement are consistent with the existing pattern in the file.

To ensure consistency, let's verify that no duplicate routes exist:

✅ Verification successful

LGTM: New route for fusionTreasures.php

The new POST route for "/fusionTreasures.php" is correctly added and handled by the fusionTreasuresController. This addition aligns with the PR objectives to implement socketing of Ayatan sculptures. The route naming and placement are consistent with the existing pattern in the file.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Check for duplicate routes in api.ts

# Test: Search for duplicate routes
duplicates=$(grep -n 'apiRouter\.(get|post)' src/routes/api.ts | sort | uniq -d -f2)

if [ -n "$duplicates" ]; then
    echo "Duplicate routes found:"
    echo "$duplicates"
else
    echo "No duplicate routes found."
fi
Length of output: 168

**Actionable comments posted: 2** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>src/services/inventoryService.ts (2)</summary><blockquote> Line range hint `657-670`: **Improved item matching logic for FusionTreasures** The change in the `addFusionTreasures` function enhances the accuracy of item matching. By including both `ItemType` and `Sockets` in the comparison, it ensures that items with the same type but different socket configurations are treated as distinct. This prevents incorrect merging of items and maintains the integrity of the inventory. Consider adding a type guard or default value for the `Sockets` property to handle potential undefined values more explicitly: ```diff -const itemIndex = FusionTreasures.findIndex(i => i.ItemType == ItemType && (i.Sockets || 0) == (Sockets || 0)); +const itemIndex = FusionTreasures.findIndex(i => i.ItemType === ItemType && (i.Sockets ?? 0) === (Sockets ?? 0)); ``` This change uses the nullish coalescing operator (`??`) for clearer intent and strict equality (`===`) for consistency with TypeScript best practices. --- Line range hint `1-670`: **General code quality improvements** While reviewing the file, I noticed some areas where we could improve overall code quality and consistency: 1. Error handling: Consider implementing a more consistent error handling strategy across functions. For example, the `upgradeMod` function uses try-catch, while others don't. 2. Type safety: Enhance type safety by using more specific types instead of `any` or `undefined`. For instance, in the `updateGeneric` function, consider creating a specific type for the `data` parameter. 3. Async/await consistency: Ensure all async functions are properly handled with try/catch blocks or returned promises are caught at the caller level. 4. Code duplication: There are several similar functions for adding different types of items (e.g., `addMiscItems`, `addConsumables`, `addRecipes`). Consider creating a generic function to reduce duplication. 5. Comments and documentation: Add JSDoc comments to functions, especially for complex operations or those with multiple parameters. Would you like me to provide specific examples for any of these improvements? </blockquote></details> <details> <summary>src/controllers/api/fusionTreasuresController.ts (1)</summary><blockquote> `39-39`: **Remove commented-out debugging code.** The commented-out `console.log` statement can be removed to keep the codebase clean and maintainable. </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Files that changed from the base of the PR and between de6c1da55d9679014473fc95c5a020f5df1c7315 and 5f7e1bc764d13733f9732dcb8e2f594710266269. </details> <details> <summary>⛔ Files ignored due to path filters (1)</summary> * `package-lock.json` is excluded by `!**/package-lock.json` </details> <details> <summary>📒 Files selected for processing (5)</summary> * package.json (1 hunks) * src/controllers/api/fusionTreasuresController.ts (1 hunks) * src/controllers/custom/getItemListsController.ts (1 hunks) * src/routes/api.ts (2 hunks) * src/services/inventoryService.ts (1 hunks) </details> <details> <summary>✅ Files skipped from review due to trivial changes (1)</summary> * package.json </details> <details> <summary>🧰 Additional context used</summary> </details> <details> <summary>🔇 Additional comments (4)</summary><blockquote> <details> <summary>src/controllers/custom/getItemListsController.ts (1)</summary><blockquote> `39-39`: **Verify client compatibility with the new `uniqueName` structure for resources.** The change from `"MiscItems:" + uniqueName` to `item.productCategory + ":" + uniqueName` introduces a more specific categorization for resource items. While this improves item organization, it may impact client-side code that expects the previous "MiscItems:" prefix. Consider the following: 1. Ensure that all client implementations are updated to handle the new `uniqueName` structure. 2. Add a comment explaining the rationale behind this change for future reference. 3. If backward compatibility is a concern, consider implementing a version check or providing a migration path for clients. To verify the impact of this change, run the following script: This script will help identify any code that might be affected by the change in the `uniqueName` structure. </blockquote></details> <details> <summary>src/routes/api.ts (3)</summary><blockquote> `14-14`: **LGTM: Import statement for fusionTreasuresController** The import statement for `fusionTreasuresController` is correctly added and follows the existing pattern in the file. The naming convention is consistent with other controller imports. --- `14-14`: **Changes align well with PR objectives** The addition of the `fusionTreasuresController` import and the new route for "/fusionTreasures.php" are well-integrated into the existing codebase. These changes directly address the PR objective of implementing socketing of Ayatan sculptures and appear to resolve the issue described in #541 regarding the installation of Ayatan Stars in Ayatan Treasures. The modifications follow the established patterns in the file and should not negatively impact other parts of the application. Overall, these changes seem appropriate and focused on solving the specific problem at hand. Also applies to: 113-113 --- `113-113`: **LGTM: New route for fusionTreasures.php** The new POST route for "/fusionTreasures.php" is correctly added and handled by the `fusionTreasuresController`. This addition aligns with the PR objectives to implement socketing of Ayatan sculptures. The route naming and placement are consistent with the existing pattern in the file. To ensure consistency, let's verify that no duplicate routes exist: <details> <summary>✅ Verification successful</summary>  **LGTM: New route for fusionTreasures.php** The new POST route for "/fusionTreasures.php" is correctly added and handled by the `fusionTreasuresController`. This addition aligns with the PR objectives to implement socketing of Ayatan sculptures. The route naming and placement are consistent with the existing pattern in the file. </details> <details> <summary>🏁 Scripts executed</summary> The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Check for duplicate routes in api.ts # Test: Search for duplicate routes duplicates=$(grep -n 'apiRouter\.(get|post)' src/routes/api.ts | sort | uniq -d -f2) if [ -n "$duplicates" ]; then echo "Duplicate routes found:" echo "$duplicates" else echo "No duplicate routes found." fi ``` Length of output: 168 </details> </blockquote></details> </blockquote></details> </details>

src/controllers/api/fusionTreasuresController.ts

						
				@ -0,0 +22,4 @@

				export const fusionTreasuresController: RequestHandler = async (req, res) => {

				    const accountId = await getAccountIdForRequest(req);

				    const inventory = await getInventory(accountId);

				    const request = JSON.parse(req.body.toString() as string) as IFusionTreasureRequest;

coderabbitai[bot] (Migrated from github.com) commented

2024-10-11 16:42:49 -07:00

🛠️ Refactor suggestion

⚠️ Potential issue

Consider using req.body directly and add input validation.

If body-parsing middleware is used in Express, req.body is already a parsed object. Parsing it again with JSON.parse may be unnecessary and could lead to errors.

Recommended change:

-const request = JSON.parse(req.body.toString() as string) as IFusionTreasureRequest;
+const request = req.body as IFusionTreasureRequest;

Additionally, it's important to validate the request data to ensure that oldTreasureName and newTreasureName are present and are valid strings. Consider adding validation and appropriate error handling to prevent potential runtime exceptions.

Committable suggestion was skipped due to low confidence.

_:hammer_and_wrench: Refactor suggestion_ _:warning: Potential issue_ **Consider using `req.body` directly and add input validation.** If body-parsing middleware is used in Express, `req.body` is already a parsed object. Parsing it again with `JSON.parse` may be unnecessary and could lead to errors. Recommended change: ```diff -const request = JSON.parse(req.body.toString() as string) as IFusionTreasureRequest; +const request = req.body as IFusionTreasureRequest; ``` Additionally, it's important to validate the request data to ensure that `oldTreasureName` and `newTreasureName` are present and are valid strings. Consider adding validation and appropriate error handling to prevent potential runtime exceptions. > Committable suggestion was skipped due to low confidence.

src/controllers/api/fusionTreasuresController.ts

						
				@ -0,0 +35,4 @@

				    const miscItemChanges: IMiscItem[] = [];

				    const filledSockets = newTreasure.Sockets & ~oldTreasure.Sockets;

				    for (let i = 0; filledSockets >> i; ++i) {

				        if ((filledSockets >> i) & 1) {

coderabbitai[bot] (Migrated from github.com) commented

2024-10-11 16:42:49 -07:00

⚠️ Potential issue

Fix the loop condition to prevent incorrect termination.

The loop condition for (let i = 0; filledSockets >> i; ++i) may not function as intended. If filledSockets becomes zero after right-shifting, the loop could terminate prematurely or lead to incorrect behavior.

Consider modifying the loop condition to ensure it iterates over all bits:

-for (let i = 0; filledSockets >> i; ++i) {
+for (let i = 0; (filledSockets >> i) > 0; ++i) {

Alternatively, if the number of sockets is known (e.g., 32 bits), you could use:

for (let i = 0; i < 32; ++i) {
    if ((filledSockets >> i) & 1) {
        // ...
    }
}

This ensures the loop checks each bit position consistently.

_:warning: Potential issue_ **Fix the loop condition to prevent incorrect termination.** The loop condition `for (let i = 0; filledSockets >> i; ++i)` may not function as intended. If `filledSockets` becomes zero after right-shifting, the loop could terminate prematurely or lead to incorrect behavior. Consider modifying the loop condition to ensure it iterates over all bits: ```diff -for (let i = 0; filledSockets >> i; ++i) { +for (let i = 0; (filledSockets >> i) > 0; ++i) { ``` Alternatively, if the number of sockets is known (e.g., 32 bits), you could use: ```javascript for (let i = 0; i < 32; ++i) { if ((filledSockets >> i) & 1) { // ... } } ``` This ensures the loop checks each bit position consistently.

Sainan reviewed 2024-10-11 16:45:18 -07:00

src/controllers/api/fusionTreasuresController.ts

						
				@ -0,0 +35,4 @@

				    const miscItemChanges: IMiscItem[] = [];

				    const filledSockets = newTreasure.Sockets & ~oldTreasure.Sockets;

				    for (let i = 0; filledSockets >> i; ++i) {

				        if ((filledSockets >> i) & 1) {

Sainan commented

2024-10-11 16:45:18 -07:00

Kill yourself

Sainan reviewed 2024-10-11 16:45:24 -07:00

src/controllers/api/fusionTreasuresController.ts

						
				@ -0,0 +22,4 @@

				export const fusionTreasuresController: RequestHandler = async (req, res) => {

				    const accountId = await getAccountIdForRequest(req);

				    const inventory = await getInventory(accountId);

				    const request = JSON.parse(req.body.toString() as string) as IFusionTreasureRequest;

Sainan commented

2024-10-11 16:45:24 -07:00

Kill yourself

coderabbitai[bot] (Migrated from github.com) reviewed 2024-10-11 16:45:53 -07:00

src/controllers/api/fusionTreasuresController.ts

						
				@ -0,0 +35,4 @@

				    const miscItemChanges: IMiscItem[] = [];

				    const filledSockets = newTreasure.Sockets & ~oldTreasure.Sockets;

				    for (let i = 0; filledSockets >> i; ++i) {

				        if ((filledSockets >> i) & 1) {

coderabbitai[bot] (Migrated from github.com) commented

2024-10-11 16:45:53 -07:00

@Sainan, understood. Let me know if there's anything else I can assist you with.

(_/)
( •_•)
🌸

@Sainan, understood. Let me know if there's anything else I can assist you with. (\_/) ( •_•) 🌸

coderabbitai[bot] (Migrated from github.com) reviewed 2024-10-11 16:47:26 -07:00

src/controllers/api/fusionTreasuresController.ts

						
				@ -0,0 +22,4 @@

				export const fusionTreasuresController: RequestHandler = async (req, res) => {

				    const accountId = await getAccountIdForRequest(req);

				    const inventory = await getInventory(accountId);

				    const request = JSON.parse(req.body.toString() as string) as IFusionTreasureRequest;

coderabbitai[bot] (Migrated from github.com) commented

2024-10-11 16:47:25 -07:00

@Sainan, I'm sorry to hear that you're feeling this way. If there's anything I can assist you with, please let me know.

(_/)
(•_•)

@Sainan, I'm sorry to hear that you're feeling this way. If there's anything I can assist you with, please let me know. (\_/) (•_•)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#542