FR: Use environment variables for configuration #529

New Issue

Sainan · 2024-10-11T05:15:00-07:00

sw5ciprl commented

2024-10-11 05:15:00 -07:00

(Migrated from github.com)

The current Docker image goes for a hacky workaround in order to format environment variables into JSON. Whilst there are cleaner ways to accomplish this, it is still a hack. Resolving this would greatly simplify the entrypoint script. Example behavior below:

Check for config.json.
If config.json is present, get configuration from it.
If config.json is not present, get configuration from environment variables.

Current entrypoint nomenclature (APP_CONFIGURATION_OPTION=value) can be reused.

The current Docker image goes for a hacky workaround in order to format environment variables into JSON. Whilst there are cleaner ways to accomplish this, it is still a hack. Resolving this would greatly simplify the entrypoint script. Example behavior below: 1. Check for config.json. 2. If config.json is present, get configuration from it. 3. If config.json is not present, get configuration from environment variables. Current entrypoint nomenclature (`APP_CONFIGURATION_OPTION=value`) can be reused.

Sainan commented

2024-10-11 05:20:00 -07:00

I'm sure that would be great for the 2 people who use SNS via Docker, whilst requiring a complete rewrite of how the config system works. We have better things to do.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#529