feat: gilded weapons #410

Merged

AMelonInsideLemon merged 4 commits from gildWeapon into main 2024-06-27 01:21:02 -07:00

Conversation 7 Commits 4 Files Changed 3 +69

AMelonInsideLemon commented 2024-06-26 06:29:44 -07:00 (Migrated from github.com)

Copy Link

Closes #397

Closes #397

OrdisPrime (Migrated from github.com) reviewed 2024-06-26 07:15:05 -07:00

src/types/inventoryTypes/commonInventoryTypes.ts

OrdisPrime (Migrated from github.com) commented 2024-06-26 07:15:05 -07:00

Copy Link

_id is converted to ItemId when converting a mongoose document to a POJO. (toJSON()).
rely on a document's _id field when handling it on the server side.

_id is converted to ItemId when converting a mongoose document to a POJO. (toJSON()). rely on a document's _id field when handling it on the server side.

OrdisPrime (Migrated from github.com) reviewed 2024-06-26 07:16:33 -07:00

src/controllers/api/gildWeaponController.ts

OrdisPrime (Migrated from github.com) commented 2024-06-26 07:16:33 -07:00

Copy Link

caterogy

caterogy

OrdisPrime (Migrated from github.com) reviewed 2024-06-26 07:17:09 -07:00

src/controllers/api/gildWeaponController.ts

OrdisPrime (Migrated from github.com) commented 2024-06-26 07:17:09 -07:00

Copy Link

foudn
"not" instead of "don't"
please be a bit more careful with your spelling, otherwise it gives the impression of rushing

foudn "not" instead of "don't" please be a bit more careful with your spelling, otherwise it gives the impression of rushing

AMelonInsideLemon (Migrated from github.com) reviewed 2024-06-26 07:38:25 -07:00

src/controllers/api/gildWeaponController.ts

AMelonInsideLemon (Migrated from github.com) commented 2024-06-26 07:38:23 -07:00

Copy Link

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

In the query the game sends - everything is capitalized, it would be wierd if one varible starts with a small letter

FSKiller (Migrated from github.com) reviewed 2024-06-26 08:05:16 -07:00

src/controllers/api/gildWeaponController.ts

FSKiller (Migrated from github.com) commented 2024-06-26 08:05:16 -07:00

Copy Link

He's talking about the typo for "category". you wrote "caterogy"

He's talking about the typo for "category". you wrote "caterogy"

AMelonInsideLemon (Migrated from github.com) reviewed 2024-06-26 08:07:00 -07:00

src/controllers/api/gildWeaponController.ts

AMelonInsideLemon (Migrated from github.com) commented 2024-06-26 08:07:00 -07:00

Copy Link

oh thanks, I should probably get some sleep

oh thanks, I should probably get some sleep

OrdisPrime (Migrated from github.com) reviewed 2024-06-26 08:23:30 -07:00

src/controllers/api/gildWeaponController.ts

OrdisPrime (Migrated from github.com) commented 2024-06-26 08:23:30 -07:00

Copy Link

all good lmao, sleep well.

all good lmao, sleep well.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#410

No description provided.