OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

Language selector for items in webui #407

Closed
AMelonInsideLemon wants to merge 5 commits from webui-lang into main
pull from: webui-lang
merge into: OpenWF:main
Conversation 6 Commits 5 Files Changed 4 +151 -17
AMelonInsideLemon commented 2024-06-25 21:47:12 -07:00 (Migrated from github.com)
Copy Link
No description provided.
Sainan reviewed 2024-06-25 21:58:43 -07:00
static/webui/script.js
@ -88,3 +88,3 @@
const req = $.get("/custom/getItemLists");
const req = $.get(`/custom/getItemLists?lang=${localStorage.getItem("lang")}`);
req.done(data => {
window.archonCrystalUpgrades = data.archonCrystalUpgrades;
Sainan commented 2024-06-25 21:58:43 -07:00
Copy Link

Is this not an issue when the localStorage does not have a "lang" field?

Is this not an issue when the localStorage does not have a "lang" field?
Sainan commented 2024-06-25 21:59:28 -07:00
Copy Link

Also, I feel like it would be better to get the dict based on the language once and then do the lookups instead of having to find the dict for every single key we want to look up.

Also, I feel like it would be better to get the dict based on the language once and then do the lookups instead of having to find the dict for every single key we want to look up.
AMelonInsideLemon (Migrated from github.com) reviewed 2024-06-25 22:31:21 -07:00
static/webui/script.js
@ -88,3 +88,3 @@
const req = $.get("/custom/getItemLists");
const req = $.get(`/custom/getItemLists?lang=${localStorage.getItem("lang")}`);
req.done(data => {
window.archonCrystalUpgrades = data.archonCrystalUpgrades;
AMelonInsideLemon (Migrated from github.com) commented 2024-06-25 22:31:21 -07:00
Copy Link

Nope, getString by default returns strings for en

Nope, getString by default returns strings for en
orzMaster (Migrated from github.com) reviewed 2024-06-26 00:16:21 -07:00
src/controllers/custom/getItemListsController.ts
orzMaster (Migrated from github.com) commented 2024-06-26 00:14:31 -07:00
Copy Link
    const dict = getDict(req.query.lang?.toString());
```suggestion const dict = getDict(req.query.lang?.toString()); ```
OrdisPrime commented 2024-06-26 07:29:37 -07:00 (Migrated from github.com)
Copy Link

@Sainan let me know once you think this is ready to be merged

@Sainan let me know once you think this is ready to be merged
Sainan commented 2024-06-26 11:33:42 -07:00
Copy Link

This will be a funny merge conflict with my PR, but yeah, I can take that burden, given that I at least know how to use Git.

This will be a funny merge conflict with my PR, but yeah, I can take that burden, given that I at least know how to use Git.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#407
No description provided.
Delete Branch "webui-lang"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?