OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat(webui): add client cheats and new account cheat "Unlock All Focus Schools" #406

Merged
Sainan merged 3 commits from cheetos into main 2024-06-27 14:08:59 -07:00
Conversation 2 Commits 3 Files Changed 4 +330 -263
Sainan commented 2024-06-25 20:20:20 -07:00
Owner
Copy Link
No description provided.
OrdisPrime (Migrated from github.com) reviewed 2024-06-26 07:31:49 -07:00
static/webui/script.js
@ -704,0 +727,4 @@
};
});
function doUnlockAllFocusSchools() {
OrdisPrime (Migrated from github.com) commented 2024-06-26 07:31:49 -07:00
Author
Owner
Copy Link

in general I noticed you like using the do prefix, however I think it doesn't add to the function name.
Just something I personally would change.

in general I noticed you like using the do prefix, however I think it doesn't add to the function name. Just something I personally would change.
Sainan reviewed 2024-06-26 11:34:33 -07:00
static/webui/script.js
@ -704,0 +727,4 @@
};
});
function doUnlockAllFocusSchools() {
Sainan commented 2024-06-26 11:34:33 -07:00
Author
Owner
Copy Link

I use this prefix for functions that are invoked from the UI as opposed to internal functions. I think it somewhat clarifies expectations.

I use this prefix for functions that are invoked from the UI as opposed to internal functions. I think it somewhat clarifies expectations.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#406
No description provided.
Delete Branch "cheetos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?