OpenWF/SpaceNinjaServer
21
23
Fork 29
Code Issues 21 Pull Requests Actions Packages Projects Releases Activity

Endo drops received on mission do not save #356

New Issue
Closed
opened 2024-06-21 18:59:04 -07:00 by VampireKitten · 10 comments
VampireKitten commented 2024-06-21 18:59:04 -07:00 (Migrated from github.com)
Copy Link

Any Endo obtained in a mission disappears from the mission results and is not added to the inventory. I will add pictures once I get Endo to drop again.

Any Endo obtained in a mission disappears from the mission results and is not added to the inventory. I will add pictures once I get Endo to drop again.
Sainan commented 2024-06-21 20:07:57 -07:00
Copy Link

Do you mean from like loot crates?

Do you mean from like loot crates?
VampireKitten commented 2024-06-21 20:13:40 -07:00 (Migrated from github.com)
Copy Link

Normal endo drops from enemies or crates. If you want a quick example to test on your end, any of the Arenas have tons of Endo drops, they shouldn't save after mission ends. This is an old issue that persisted since at least february.

Normal endo drops from enemies or crates. If you want a quick example to test on your end, any of the Arenas have tons of Endo drops, they shouldn't save after mission ends. This is an old issue that persisted since at least february.
Sainan commented 2024-06-21 20:20:37 -07:00
Copy Link

Could you try checking out https://github.com/spaceninjaserver/SpaceNinjaServer/pull/359 locally and seeing if it fixes the issue?

Could you try checking out https://github.com/spaceninjaserver/SpaceNinjaServer/pull/359 locally and seeing if it fixes the issue?
VampireKitten commented 2024-06-21 20:50:39 -07:00 (Migrated from github.com)
Copy Link

Will do in the morning

Will do in the morning
VampireKitten commented 2024-06-22 06:35:47 -07:00 (Migrated from github.com)
Copy Link

Quick test WITHOUT the new PR:
Rathum, Arena, got an Endo drop:

image

Mission ends, no Endo on end screen result:

image

And no Endo on fusion menu:

image

Quick test WITHOUT the new PR: Rathum, Arena, got an Endo drop: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/25277470-bc4e-45f8-a385-ae3907bbf475) Mission ends, no Endo on end screen result: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/bdab5f77-adb4-4e9f-a0a3-579d6431a99c) And no Endo on fusion menu: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/d519f4ef-7b67-41d9-9d96-df1ab5135eb4)
VampireKitten commented 2024-06-22 06:46:34 -07:00 (Migrated from github.com)
Copy Link

Test WITH new PR:
Obtained Endo Drop in mission:

image

Does not show up in end results:

image

Does not appear in mod tab:

image

Test WITH new PR: Obtained Endo Drop in mission: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/1ca63dd2-cfd8-48df-878b-d876cd1acb5a) Does not show up in end results: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/ab7727cc-fded-4d39-9c4d-487663c4a567) Does not appear in mod tab: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/8785a568-9f3c-44b2-ad23-02ba045d89ed)
Sainan commented 2024-06-22 07:10:34 -07:00
Copy Link

I see, so the way this is handled is actually completely different from what they coded in here:
image

I see, so the way this is handled is actually completely different from what they coded in here: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/63328889/ac28f65c-2c98-4e06-ab15-6af8d3401345)
Sainan commented 2024-06-22 07:41:40 -07:00
Copy Link

Should be fixed now by my PR for real.

Should be fixed now by my PR for real.
VampireKitten commented 2024-06-22 07:44:05 -07:00 (Migrated from github.com)
Copy Link

Will test as soon as I'm done with this Alert

Will test as soon as I'm done with this Alert
VampireKitten commented 2024-06-22 07:57:27 -07:00 (Migrated from github.com)
Copy Link

I can confirm it was, indeed, fixed now by your PR for real:

image

I can confirm it was, indeed, fixed now by your PR for real: ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/95658710/17968fdb-3a93-4b18-a564-a6b89036cfe4)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#356
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?