OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 43 Pull Requests 4 Actions Packages Projects Releases Activity

Add Infinite Platinum Option #346

Closed
VampireKitten wants to merge 12 commits from vamp-dev into main
pull from: vamp-dev
merge into: OpenWF:main
Conversation 4 Commits 12 Files Changed 7 +30 -13
VampireKitten commented 2024-06-21 13:07:07 -07:00 (Migrated from github.com)
Copy Link

Adds an infinite Platinum option on the config (and credit controller's associated logic) to give players the option to have infinite premium currency for in-game cosmetics while still needing to farm credits and other resources.

Adds an infinite Platinum option on the config (and credit controller's associated logic) to give players the option to have infinite premium currency for in-game cosmetics while still needing to farm credits and other resources.
Sainan approved these changes 2024-06-21 13:43:33 -07:00
VampireKitten commented 2024-06-29 06:15:05 -07:00 (Migrated from github.com)
Copy Link

If there's anything else that should be done before this is merged, please kindly inform me.

If there's anything else that should be done before this is merged, please kindly inform me.
OrdisPrime (Migrated from github.com) reviewed 2024-07-01 03:30:31 -07:00
src/controllers/api/getCreditsController.ts
@ -27,0 +29,4 @@
RegularCredits: inventory.RegularCredits,
TradesRemaining: inventory.TradesRemaining,
PremiumCreditsFree: 999999999,
PremiumCredits: 999999999
OrdisPrime (Migrated from github.com) commented 2024-07-01 03:30:31 -07:00
Copy Link

formatting - are you not using prettier?

formatting - are you not using prettier?
OrdisPrime commented 2024-07-01 03:41:14 -07:00 (Migrated from github.com)
Copy Link

infinite resources and infinite platinum both contain infinite platinum.
I would change that.

Also you will need to resolve the merge conflict, it's not rocket science, you got this.

infinite resources and infinite platinum both contain infinite platinum. I would change that. Also you will need to resolve the merge conflict, it's not rocket science, you got this.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#346
No description provided.
Delete Branch "vamp-dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?