OpenWF/SpaceNinjaServer
28
29
Fork 36
Code Issues 29 Pull Requests 5 Actions Packages Projects Releases Activity

WebUI: Import "Successfully Imported" despite error #2998

New Issue
Closed
opened 2025-11-05 07:34:50 -08:00 by Animan8000 · 3 comments
Animan8000 commented 2025-11-05 07:34:50 -08:00
Contributor
Copy Link

If the user does a mistake like:

{
      "Tag": "EventNode24",
      "Completes": 1
}

Then the WebUI says that it was successfully imported even though nothing was imported at all (obvious, since this is incorrect in the first place but WebUI states otherwise). Nothing being added into inventory in the first place but WebUI says otherwise

If the user does a mistake like: ``` { "Tag": "EventNode24", "Completes": 1 } ``` Then the WebUI says that it was successfully imported even though nothing was imported at all (obvious, since this is incorrect in the first place but WebUI states otherwise). Nothing being added into inventory in the first place but WebUI says otherwise
Sainan commented 2025-11-05 07:45:12 -08:00
Owner
Copy Link

Duplicate of #2996

Duplicate of #2996
Animan8000 commented 2025-11-05 07:46:14 -08:00
Author
Contributor
Copy Link

They're both different, no? Although both related to user error (just different outcomes in form of different bugs)

They're both different, no? Although both related to user error (just different outcomes in form of different bugs)
Sainan reopened this issue 2025-11-05 07:50:32 -08:00
Sainan commented 2025-11-05 07:51:01 -08:00
Owner
Copy Link

I guess it is different when you provide no valid fields and it could maybe be flagged as a potential issue but would need some rewriting.

I guess it is different when you provide no valid fields and it could maybe be flagged as a potential issue but would need some rewriting.
Sainan added the improvement label 2025-11-05 07:51:06 -08:00
Sainan added the pr'd for label 2025-11-05 07:59:35 -08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
An existing implemention is incorrect
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 enhancement
New feature or request specific to the emulator
 help wanted
Extra attention is needed
 improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
 pr'd for
Soon™
 question
Further information is requested
 unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label improvement pr'd for
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AMelonInsideLemon Ember OrdisPrime Sainan
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?