OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 45 Pull Requests Actions Packages Projects Releases Activity

feat: purchase ship decorations #299

Merged
Sainan merged 1 commits from deco-purchase into main 2024-06-15 06:12:08 -07:00
Conversation 3 Commits 1 Files Changed 1 +65 -13
Sainan commented 2024-06-15 05:55:46 -07:00
Owner
Copy Link

Previously, you could already "purchase" most of them, but because they were added to MiscItems instead of ShipDecorations, they weren't actually usable.

Closes #207

Previously, you could already "purchase" most of them, but because they were added to MiscItems instead of ShipDecorations, they weren't actually usable. Closes #207
OrdisPrime (Migrated from github.com) reviewed 2024-06-15 06:06:49 -07:00
src/services/inventoryService.ts
OrdisPrime (Migrated from github.com) commented 2024-06-15 06:06:32 -07:00
Author
Owner
Copy Link

why do we save default items as miscItems? is everything that is a default item a misc item?

why do we save default items as miscItems? is everything that is a default item a misc item?
src/services/inventoryService.ts
OrdisPrime (Migrated from github.com) commented 2024-06-15 06:05:06 -07:00
Author
Owner
Copy Link

markModified is only needed for Schema.Mixed.
It should not be used. Mongoose tracks changes automatically, if there is a schema for the path.

markModified is only needed for Schema.Mixed. It should not be used. Mongoose tracks changes automatically, if there is a schema for the path.
Sainan reviewed 2024-06-15 06:08:43 -07:00
src/services/inventoryService.ts
Sainan commented 2024-06-15 06:08:43 -07:00
Author
Owner
Copy Link

I just copied the existing code for addMiscItems etc.

I just copied the existing code for addMiscItems etc.
Sainan reviewed 2024-06-15 06:09:28 -07:00
src/services/inventoryService.ts
Sainan commented 2024-06-15 06:09:28 -07:00
Author
Owner
Copy Link

I don't know, but I just wanted to keep the same behaviour for everything that is not a ship decoration.

I don't know, but I just wanted to keep the same behaviour for everything that is not a ship decoration.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#299
No description provided.
Delete Branch "deco-purchase"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?