OpenWF/SpaceNinjaServer
28
29
Fork 36
Code Issues 29 Pull Requests 5 Actions Packages Projects Releases Activity

fix: handle fake jobs without syndicateMissionId #2982

Merged
Sainan merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:fix-fake-jobs into main 2025-11-03 23:56:33 -08:00
Conversation 2 Commits 2 Files Changed 1 +69 -62
AMelonInsideLemon commented 2025-11-02 11:35:20 -08:00
Member
Copy Link

Closes #2970

Closes #2970
AMelonInsideLemon added 1 commit 2025-11-02 11:35:21 -08:00
fix: handle fake jobs without syndicateMissionId
All checks were successful
Build / build (pull_request) Successful in 1m56s
Details
65f6c7a439 
Re #2970
Sainan reviewed 2025-11-02 11:52:00 -08:00
src/services/missionInventoryUpdateService.ts Outdated
@@ -1521,0 +1543,4 @@
{ endings: ["Jobs/NewbieJob"], amount: 200, tag: "CetusSyndicate" }
];
if (specialCase.some(rule => rule.endings.some(e => jobType.endsWith(e)))) {
const specialCaseReward = specialCase.find(
Sainan commented 2025-11-02 11:52:00 -08:00
Owner
Copy Link

specialCase.find after specialCase.some seems wasteful as you're linearlly iterating over the array twice.

`specialCase.find` after `specialCase.some` seems wasteful as you're linearlly iterating over the array twice.
AMelonInsideLemon marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-11-02 13:05:55 -08:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 59s
Details
69d816e3ad
Sainan approved these changes 2025-11-02 23:25:09 -08:00
Sainan merged commit 2264ae176b into main 2025-11-03 23:56:33 -08:00
Sainan deleted branch fix-fake-jobs 2025-11-03 23:56:37 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 enhancement
New feature or request specific to the emulator
 help wanted
Extra attention is needed
 improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
 pr'd for
Soon™
 question
Further information is requested
 unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AMelonInsideLemon Ember OrdisPrime Sainan
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2982
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:fix-fake-jobs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?