OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

WebUI: Mark quest as inactive before deleting it (otherwise player gets softlocked when accessing star chart) #2958

New Issue
Open
opened 2025-10-30 13:24:03 -07:00 by Animan8000 · 0 comments
Animan8000 commented 2025-10-30 13:24:03 -07:00
Contributor
Copy Link

If you delete for example Saya's Vigil, that is currently set as "active" in advance in WebUI and then access star chart, you may get softlocked every time you access star chart. If you re-add the quest, then it will still be set as active (as if it was never deleted). I think it's important that when a quest gets deleted, that its automatically set as inactive, to prevent softlocks.

{35C3A0CA-9897-4BE6-A711-B0DFF6460DB8}.png
If you delete for example Saya's Vigil, that is currently set as "active" in advance in WebUI and then access star chart, you may get softlocked every time you access star chart. If you re-add the quest, then it will still be set as active (as if it was never deleted). I think it's important that when a quest gets deleted, that its automatically set as inactive, to prevent softlocks. <img width="1440" alt="{35C3A0CA-9897-4BE6-A711-B0DFF6460DB8}.png" src="attachments/cd35811a-581d-4d99-9481-1e8bea216cca">
{35C3A0CA-9897-4BE6-A711-B0DFF6460DB8}.png
3.1 MiB
Sainan added the
improvement
 label 2025-10-30 13:54:05 -07:00
Sainan added the
pr'd for
 label 2025-10-31 01:49:34 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
improvement
pr'd for
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2958
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?