OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 24 Pull Requests 2 Actions Packages Projects Releases Activity

chore(webui): clarify /sync command goes into chat #2835

Merged
Sainan merged 4 commits from :fix/improving-description into main 2025-10-03 06:45:58 -07:00
Conversation 16 Commits 4 Files Changed 3 +4 -4
LoseFace commented 2025-10-01 04:24:16 -07:00
Contributor
Copy Link
No description provided.
LoseFace added 1 commit 2025-10-01 04:24:16 -07:00
chore(webui): improving description en.js
Some checks failed
Build / build (pull_request) Failing after 1m9s
Details
393ab62f28
Sainan commented 2025-10-01 04:34:32 -07:00
Owner
Copy Link

This is incorrect because /sync is not a command in the normal game and relies on a pretty specific setup to work (Bootstrapper DLL + Chat Commands.pluto). This setup may be the default/majority right now, but such assumptions won't age well.

This is incorrect because /sync is not a command in the normal game and relies on a pretty specific setup to work (Bootstrapper DLL + Chat Commands.pluto). This setup may be the default/majority right now, but such assumptions won't age well.
Animan8000 commented 2025-10-01 04:36:59 -07:00
Contributor
Copy Link

using the bootstrapper's /sync chat command in-game

Probably fits better?

`using the bootstrapper's /sync chat command in-game` Probably fits better?
LoseFace commented 2025-10-01 04:37:44 -07:00
Author
Contributor
Copy Link

This is incorrect because /sync is not a command in the normal game

But this isn't a "normal" game and the current description is a little misleading, suggesting that you can enter commands in the Bootstrapper. I also don't understand this logic, since we can also use the command to move to a dojo/relay/other existing room.

> This is incorrect because /sync is not a command in the normal game But this isn't a "normal" game and the current description is a little misleading, suggesting that you can enter commands in the Bootstrapper. I also don't understand this logic, since we can also use the command to move to a dojo/relay/other existing room.
Animan8000 commented 2025-10-01 04:40:16 -07:00
Contributor
Copy Link

This is incorrect because /sync is not a command in the normal game

But this isn't a "normal" game and the current description is a little misleading, suggesting that you can enter commands in the Bootstrapper.

Well you cannot enter a command in the CLI of the bootstrapper anyway. The only issue I see is that it might not be 100% obvious to the end user that /sync is meant for in-game chat, with the current description. So having an updated description is still a good idea

> > This is incorrect because /sync is not a command in the normal game > > But this isn't a "normal" game and the current description is a little misleading, suggesting that you can enter commands in the Bootstrapper. Well you cannot enter a command in the CLI of the bootstrapper anyway. The only issue I see is that it might not be 100% obvious to the end user that `/sync` is meant for in-game chat, with the current description. So having an updated description is still a good idea
Sainan commented 2025-10-01 04:45:31 -07:00
Owner
Copy Link

I think I would just add a little clarification at the end: "you need to resync your inventory, e.g. using the bootstrapper's /sync command in game chat"

I think I would just add a little clarification at the end: "you need to resync your inventory, e.g. using the bootstrapper's /sync command __in game chat__"
👍 2
LoseFace commented 2025-10-01 04:55:28 -07:00
Author
Contributor
Copy Link

"you need to resync your inventory, e.g. using the bootstrapper's /sync command in game chat"

That's even better.

> "you need to resync your inventory, e.g. using the bootstrapper's /sync command **in game chat**" That's even better.
Animan8000 commented 2025-10-01 04:59:02 -07:00
Contributor
Copy Link

Might also wanna update it for languages where this isn't translated yet, to update the untranslated strings.

Might also wanna update it for languages where this isn't translated yet, to update the untranslated strings.
👍 1
Sainan commented 2025-10-01 07:50:23 -07:00
Owner
Copy Link

Yes, CI is failing because you didn't run npm run update-translations. Address these 2 things and we can merge this. :)

Yes, CI is failing because you didn't run `npm run update-translations`. Address these 2 things and we can merge this. :)
Sainan changed title from chore(webui): improving description en.js to WIP: chore(webui): improving description en.js 2025-10-02 05:27:50 -07:00
Animan8000 commented 2025-10-02 12:02:56 -07:00
Contributor
Copy Link

@LoseFace You need to update your Pull Request (by making commits), otherwise we cannot merge the changes :P

@LoseFace You need to update your Pull Request (by making commits), otherwise we cannot merge the changes :P
LoseFace added 1 commit 2025-10-02 12:16:25 -07:00
chore(webui): improving description en.js
Some checks failed
Build / build (pull_request) Failing after 1m11s
Details
fbaf02fbc4
LoseFace commented 2025-10-02 12:17:59 -07:00
Author
Contributor
Copy Link

You need to update your Pull Request (by making commits), otherwise we cannot merge the changes :P

Like this? Sorry, I'm still not very good at this system.

> You need to update your Pull Request (by making commits), otherwise we cannot merge the changes :P Like this? Sorry, I'm still not very good at this system.
LoseFace changed title from WIP: chore(webui): improving description en.js to chore(webui): improving description en.js 2025-10-02 12:18:47 -07:00
Sainan commented 2025-10-02 12:38:15 -07:00
Owner
Copy Link

You still need to run npm run update-translations and commit the result to fix the CI failure

You still need to run `npm run update-translations` and commit the result to fix the CI failure
LoseFace commented 2025-10-02 12:45:18 -07:00
Author
Contributor
Copy Link

You still need to run npm run update-translations and commit the result to fix the CI failure

I don't understand what is required of me(

> You still need to run `npm run update-translations` and commit the result to fix the CI failure I don't understand what is required of me(
LoseFace added 1 commit 2025-10-02 12:46:23 -07:00
merge upstream
Some checks failed
Build / build (pull_request) Failing after 1m5s
Details
8660f5ff36
LoseFace commented 2025-10-02 12:47:15 -07:00
Author
Contributor
Copy Link

Is that it?

Is that it?
Sainan commented 2025-10-02 13:04:35 -07:00
Owner
Copy Link

No, it's still failing as you can see

No, it's still failing as you can see
LoseFace commented 2025-10-02 13:13:39 -07:00
Author
Contributor
Copy Link

No, it's still failing as you can see

I still don't understand. Can you update the description yourself?

> No, it's still failing as you can see I still don't understand. Can you update the description yourself?
Sainan added 1 commit 2025-10-02 13:22:57 -07:00
npm run update-translations
All checks were successful
Build / build (pull_request) Successful in 1m10s
Details
5e0625bb45
Sainan changed title from chore(webui): improving description en.js to chore(webui): clarify /sync command goes into chat 2025-10-02 13:23:10 -07:00
Sainan approved these changes 2025-10-02 13:23:21 -07:00
Sainan merged commit 0136e4d152 into main 2025-10-03 06:45:58 -07:00
Sainan deleted branch fix/improving-description 2025-10-03 06:45:58 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2835
No description provided.
Delete Branch ":fix/improving-description"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?