OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 24 Pull Requests 2 Actions Packages Projects Releases Activity

chore(webui): fix typos #2832

Merged
Sainan merged 20 commits from :main into main 2025-10-01 01:23:08 -07:00
Conversation 9 Commits 20 Files Changed 4 +8 -8
Animan8000 commented 2025-09-30 05:08:45 -07:00
Contributor
Copy Link

also updated author credits

also updated author credits
Animan8000 added 8 commits 2025-09-30 05:08:45 -07:00
static/webui/translations/fr.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m7s
Details
40c8bfbac9
Slayer55555 commented 2025-09-30 05:29:17 -07:00
Contributor
Copy Link

Spanish and French translation seems to be fine with cheats_unlockSuccInventory

Why revert to untranslated then?

Also in Spanish inventory_addItemByItemType_warning you only need to remove the comma. Like this:

Usa esta función bajo tu propio riesgo. Podría dañar tu inventario y tendrías que eliminar los objetos manualmente si algo sale mal

> Spanish and French translation seems to be fine with `cheats_unlockSuccInventory` Why revert to untranslated then? Also in Spanish `inventory_addItemByItemType_warning` you only need to remove the comma. Like this: _Usa esta función bajo tu propio riesgo. Podría dañar tu inventario y tendrías que eliminar los objetos manualmente si algo sale mal_
Animan8000 commented 2025-09-30 05:39:51 -07:00
Author
Contributor
Copy Link

Why revert to untranslated then?

It isn't untranslated as it's fine (no extra dot present in the Spanish one)

Also in Spanish inventory_addItemByItemType_warning you only need to remove the comma. Like this:

Usa esta función bajo tu propio riesgo. Podría dañar tu inventario y tendrías que eliminar los objetos manualmente si algo sale mal

I applied it now

> Why revert to untranslated then? It isn't untranslated as it's fine (no extra dot present in the Spanish one) > Also in Spanish `inventory_addItemByItemType_warning` you only need to remove the comma. Like this: > > _Usa esta función bajo tu propio riesgo. Podría dañar tu inventario y tendrías que eliminar los objetos manualmente si algo sale mal_ I applied it now
Animan8000 added 1 commit 2025-09-30 05:40:17 -07:00
static/webui/translations/es.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m18s
Details
8e8ce9b89a
Sainan reviewed 2025-09-30 07:55:40 -07:00
static/webui/translations/es.js Outdated
@ -194,3 +194,3 @@
cheats_skipAllDialogue: `Omitir todos los diálogos`,
cheats_unlockAllScans: `Desbloquear todos los escaneos`,
cheats_unlockSuccRelog: `Éxito. Ten en cuenta que deberás volver a iniciar sesión para que el cliente se actualice.`,
cheats_unlockSuccRelog: `[UNTRANSLATED] Success. Please note that you'll need to relog for the client to refresh this.`,
Sainan commented 2025-09-30 07:55:40 -07:00
Owner
Copy Link

Revert this change

Revert this change
Animan8000 marked this conversation as resolved
Sainan reviewed 2025-09-30 07:55:54 -07:00
static/webui/translations/fr.js Outdated
@ -194,3 +194,3 @@
cheats_skipAllDialogue: `Passer les dialogues`,
cheats_unlockAllScans: `Débloquer tous les scans`,
cheats_unlockSuccRelog: `Succès. Une reconnexion est requise pour appliquer les changements.`,
cheats_unlockSuccRelog: `[UNTRANSLATED] Success. Please note that you'll need to relog for the client to refresh this.`,
Sainan commented 2025-09-30 07:55:54 -07:00
Owner
Copy Link

Revert this change.

Revert this change.
Animan8000 marked this conversation as resolved
Sainan reviewed 2025-09-30 07:56:25 -07:00
static/webui/translations/ru.js Outdated
@ -194,3 +194,3 @@
cheats_skipAllDialogue: `Пропустить все диалоги`,
cheats_unlockAllScans: `Разблокировать все сканирования`,
cheats_unlockSuccRelog: `Успех. Вам необходимо повторно войти в игру, чтобы клиент обновил эту информацию.`,
cheats_unlockSuccRelog: `[UNTRANSLATED] Success. Please note that you'll need to relog for the client to refresh this.`,
Sainan commented 2025-09-30 07:56:25 -07:00
Owner
Copy Link

Revert this change.

Revert this change.
Animan8000 marked this conversation as resolved
Sainan reviewed 2025-09-30 07:57:32 -07:00
static/webui/translations/en.js Outdated
@ -93,3 +93,3 @@
inventory_addItems: `Add Items`,
inventory_addItemByItemType: `Raw`,
inventory_addItemByItemType_warning: `Use this feature at your own risk. It may break your inventory, and you will need to remove items manually if something goes wrong.`,
inventory_addItemByItemType_warning: `Use this feature at your own risk. It may break your inventory and you will need to remove items manually if something goes wrong.`,
Sainan commented 2025-09-30 07:57:32 -07:00
Owner
Copy Link

The comma here is correct. Please revert it across all files.

The comma here is correct. Please revert it across all files.
Animan8000 marked this conversation as resolved
Sainan reviewed 2025-09-30 07:57:50 -07:00
static/webui/translations/uk.js
@ -195,3 +195,3 @@
cheats_unlockAllScans: `Розблокувати всі сканування`,
cheats_unlockSuccRelog: `Успіх. Вам потрібно буде повторно увійти в гру, щоб клієнт оновив цю інформацію.`,
cheats_unlockSuccRelog: `[UNTRANSLATED] Success. Please note that you'll need to relog for the client to refresh this.`,
cheats_unlockAllMissions: `Розблокувати всі місії`,
Sainan commented 2025-09-30 07:57:50 -07:00
Owner
Copy Link

Revert this change.

Revert this change.
Animan8000 marked this conversation as resolved
Animan8000 changed title from chore(webui): fixing some errors in strings to WIP: chore(webui): fixing some errors in strings 2025-09-30 08:36:43 -07:00
Animan8000 added 1 commit 2025-09-30 09:21:11 -07:00
static/webui/translations/es.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m5s
Details
cfbbca6134
Animan8000 added 1 commit 2025-09-30 09:23:04 -07:00
static/webui/translations/fr.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m32s
Details
602311f9e3
Animan8000 added 1 commit 2025-09-30 10:09:59 -07:00
static/webui/translations/ru.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m31s
Details
b12dccf212
Animan8000 added 1 commit 2025-09-30 10:12:01 -07:00
static/webui/translations/uk.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 4m16s
Details
b171a73430
Animan8000 added 1 commit 2025-09-30 10:16:26 -07:00
static/webui/translations/de.js aktualisiert
Some checks failed
Build / build (pull_request) Failing after 1m15s
Details
6ac673a769
Animan8000 added 1 commit 2025-09-30 10:17:05 -07:00
static/webui/translations/en.js aktualisiert
Some checks failed
Build / build (pull_request) Failing after 3m6s
Details
698f418617
Animan8000 added 1 commit 2025-09-30 10:34:15 -07:00
static/webui/translations/es.js aktualisiert
Some checks failed
Build / build (pull_request) Failing after 2m45s
Details
8a790ab55f
Animan8000 added 1 commit 2025-09-30 10:35:10 -07:00
static/webui/translations/zh.js aktualisiert
Some checks failed
Build / build (pull_request) Failing after 1m4s
Details
20de230ea3
Animan8000 added 1 commit 2025-09-30 10:36:39 -07:00
static/webui/translations/uk.js aktualisiert
Some checks failed
Build / build (pull_request) Failing after 1m31s
Details
6bcf569ed3
Animan8000 added 1 commit 2025-09-30 10:37:20 -07:00
static/webui/translations/ru.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 3m6s
Details
ca8db6b1ee
Animan8000 added 1 commit 2025-09-30 10:38:56 -07:00
static/webui/translations/es.js aktualisiert
All checks were successful
Build / build (pull_request) Successful in 1m32s
Details
74800b0aa0
Animan8000 changed title from WIP: chore(webui): fixing some errors in strings to chore(webui): fixing some errors in strings 2025-09-30 11:03:06 -07:00
Animan8000 commented 2025-09-30 11:03:24 -07:00
Author
Contributor
Copy Link

Should be good now I think?

Should be good now I think?
Sainan approved these changes 2025-09-30 11:10:20 -07:00
Sainan changed title from chore(webui): fixing some errors in strings to chore(webui): fix typos 2025-10-01 01:22:41 -07:00
Sainan merged commit 6e8800f048 into main 2025-10-01 01:23:08 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2832
No description provided.
Delete Branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?