OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 24 Pull Requests 2 Actions Packages Projects Releases Activity

feat: Nights of Naberus #2817

Merged
Sainan merged 13 commits from Slayer55555/SpaceNinjaServer:main into main 2025-09-29 23:59:18 -07:00
Conversation 8 Commits 13 Files Changed 11 +48
Slayer55555 commented 2025-09-26 22:59:22 -07:00
Contributor
Copy Link
No description provided.
Slayer55555 added 1 commit 2025-09-26 22:59:23 -07:00
naberus
All checks were successful
Build / build (pull_request) Successful in 1m2s
Details
304b0b347b
Sainan commented 2025-09-27 03:26:23 -07:00
Owner
Copy Link

I love me a PR from main. Anyway, you marked Warframe Anniversary as incompatible with Naberus, but Naberus is not marked incompatible with Warframe Anniversary?

I love me a PR from `main`. Anyway, you marked Warframe Anniversary as incompatible with Naberus, but Naberus is not marked incompatible with Warframe Anniversary?
Sainan commented 2025-09-27 03:27:09 -07:00
Owner
Copy Link

Functionality-wise, I see no issue, but I'm not sure if this is the best way of doing it. I would rather something similar to dog days, star days, etc. where the appearance of the event happens automatically with the only manual part being if you want to override it.

Functionality-wise, I see no issue, but I'm not sure if this is the best way of doing it. I would rather something similar to dog days, star days, etc. where the appearance of the event happens automatically with the only manual part being if you want to override it.
Slayer55555 commented 2025-09-27 07:22:19 -07:00
Author
Contributor
Copy Link

Yeah was testing stuff on my pc and said why not try a PR, forgot to make a branch, bad habit.
I also should test a little more with compatibility with other events.
Will check later the dog days stuff.

Yeah was testing stuff on my pc and said why not try a PR, forgot to make a branch, bad habit. I also should test a little more with compatibility with other events. Will check later the dog days stuff.
Slayer55555 added 1 commit 2025-09-27 11:11:00 -07:00
merge upstream
All checks were successful
Build / build (pull_request) Successful in 1m31s
Details
9ca74bf6ee
Slayer55555 added 1 commit 2025-09-27 11:17:38 -07:00
spooky month
Some checks failed
Build / build (pull_request) Failing after 3m21s
Details
db472d25cf
Slayer55555 added 1 commit 2025-09-27 11:19:07 -07:00
Spooky Month webui edition
Some checks failed
Build / build (pull_request) Failing after 1m30s
Details
7b7e1d6beb
Slayer55555 added 1 commit 2025-09-27 11:25:08 -07:00
Update static/webui/index.html
Some checks failed
Build / build (pull_request) Failing after 59s
Details
73bda1e5b3
Slayer55555 added 1 commit 2025-09-27 11:30:02 -07:00
Update src/services/worldStateService.ts
All checks were successful
Build / build (pull_request) Successful in 1m29s
Details
3d4923dbca
Slayer55555 commented 2025-09-27 11:33:51 -07:00
Author
Contributor
Copy Link

Should be working, already tested it by changing the date on my pc.

Should be working, already tested it by changing the date on my pc.
Sainan reviewed 2025-09-27 11:35:57 -07:00
Slayer55555 added 1 commit 2025-09-27 11:58:52 -07:00
fix vanilla config
All checks were successful
Build / build (pull_request) Successful in 3m31s
Details
e0ad8a172d
Slayer55555 added 1 commit 2025-09-27 12:00:09 -07:00
fix naberus webui
All checks were successful
Build / build (pull_request) Successful in 1m30s
Details
377e70f4c6
Slayer55555 added 1 commit 2025-09-27 12:01:29 -07:00
fix worldStateService
Some checks failed
Build / build (pull_request) Failing after 3m16s
Details
6a8591a272
Slayer55555 added 1 commit 2025-09-27 12:02:14 -07:00
fix configServices
All checks were successful
Build / build (pull_request) Successful in 1m30s
Details
b65f205715
Sainan reviewed 2025-09-28 01:14:12 -07:00
config-vanilla.json Outdated
@ -34,6 +34,7 @@
"wolfHunt": false,
"orphixVenom": false,
"longShadow": false,
"naberusNightsOverride": null,
Sainan commented 2025-09-28 01:14:12 -07:00
Owner
Copy Link

Should be moved below hallowedNightmaresRewardsOverride here and in typings for consistency with webui

Should be moved below hallowedNightmaresRewardsOverride here and in typings for consistency with webui
Slayer55555 marked this conversation as resolved
Sainan reviewed 2025-09-28 01:14:34 -07:00
static/webui/index.html Outdated
@ -1208,2 +1208,4 @@
</div>
</div>
<div class="form-group mt-2">
<label class="form-label" for="worldState.naberusNightsOverride" data-loc="worldState_naberusNightsOverride"></label>
Sainan commented 2025-09-28 01:14:34 -07:00
Owner
Copy Link

worldState_naberusNightsOverride is missing in translations

worldState_naberusNightsOverride is missing in translations
Slayer55555 marked this conversation as resolved
Slayer55555 added 1 commit 2025-09-28 10:05:53 -07:00
merge upstream
All checks were successful
Build / build (pull_request) Successful in 1m6s
Details
3f55544875
Slayer55555 added 1 commit 2025-09-28 10:53:24 -07:00
fix webui translations + reorder config
All checks were successful
Build / build (pull_request) Successful in 59s
Details
e051ce2709
Sainan added 1 commit 2025-09-29 01:58:25 -07:00
fix location of naberus nights in translations
All checks were successful
Build / build (pull_request) Successful in 1m3s
Details
4d23d1a131
Sainan approved these changes 2025-09-29 01:59:39 -07:00
Sainan merged commit 9426359370 into main 2025-09-29 23:59:18 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2817
No description provided.
Delete Branch "Slayer55555/SpaceNinjaServer:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?