OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 24 Pull Requests 2 Actions Packages Projects Releases Activity

fix: determine armor or shield based on sortie boss faction #2787

Merged
Sainan merged 3 commits from sortie-faction-fix into main 2025-09-18 01:12:26 -07:00
Conversation 2 Commits 3 Files Changed 1 +5 -10
Sainan commented 2025-09-17 06:15:47 -07:00
Owner
Copy Link

Closes #2785

Closes #2785
Sainan added 1 commit 2025-09-17 06:15:47 -07:00
fix: don't use armor/shield sortie modifiers when faction is infestation
All checks were successful
Build / build (pull_request) Successful in 1m24s
Details
9593971759
Animan8000 commented 2025-09-17 06:26:58 -07:00
Contributor
Copy Link

I'm very sure armor is intended & actually working. Shield however isn't

I'm very sure armor **is** intended & actually working. Shield however isn't
Animan8000 commented 2025-09-17 06:30:07 -07:00
Contributor
Copy Link
{581C485F-4C8A-49D7-A579-2C22AB794F9C}.png

which Grineer, Corrupted & Infestation can have

<img width="403" alt="{581C485F-4C8A-49D7-A579-2C22AB794F9C}.png" src="attachments/f66bf1d2-7bce-4e67-a36f-9ad4ace3b5aa"> which Grineer, Corrupted & Infestation can have
{581C485F-4C8A-49D7-A579-2C22AB794F9C}.png
19 KiB
Sainan added 1 commit 2025-09-17 06:34:58 -07:00
fix: determine armor or shield based on sortie boss faction
All checks were successful
Build / build (pull_request) Successful in 1m13s
Details
a9657829f8
Sainan changed title from fix: don't use armor/shield sortie modifiers when faction is infestation to fix: determine armor or shield based on sortie boss faction 2025-09-17 06:34:59 -07:00
Sainan added 1 commit 2025-09-17 06:36:35 -07:00
fix this note here
All checks were successful
Build / build (pull_request) Successful in 1m14s
Details
cab63ced90
Sainan merged commit c47c60fdcc into main 2025-09-18 01:12:26 -07:00
Sainan deleted branch sortie-faction-fix 2025-09-18 01:12:26 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2787
No description provided.
Delete Branch "sortie-faction-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?