OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 43 Pull Requests 4 Actions Packages Projects Releases Activity

improve: adding special weapons at powersuit creation #277

Merged
AMelonInsideLemon merged 10 commits from SpecialItems into main 2024-06-07 06:58:20 -07:00
Conversation 4 Commits 10 Files Changed 4 +45 -3
AMelonInsideLemon commented 2024-06-04 04:03:19 -07:00 (Migrated from github.com)
Copy Link
No description provided.
Sainan commented 2024-06-04 04:11:24 -07:00
Copy Link

LGTM. Tho I think IGenericItem2 could be removed enitrely now as it seems that was only used for SpecialItems. 🤔

LGTM. Tho I think `IGenericItem2` could be removed enitrely now as it seems that was only used for SpecialItems. 🤔
AMelonInsideLemon commented 2024-06-04 04:16:44 -07:00 (Migrated from github.com)
Copy Link

LGTM. Tho I think IGenericItem2 could be removed enitrely now as it seems that was only used for SpecialItems. 🤔

Me too, i can't find any lines from IGenericItem2 in my inventory dump

> LGTM. Tho I think `IGenericItem2` could be removed enitrely now as it seems that was only used for SpecialItems. 🤔 Me too, i can't find any lines from `IGenericItem2` in my inventory dump
Sainan commented 2024-06-04 04:17:35 -07:00
Copy Link

This whole thing has been a mess. I think this actually does a decent job of resolving #236, haha.

This whole thing has been a mess. I think this actually does a decent job of resolving #236, haha.
OrdisPrime (Migrated from github.com) reviewed 2024-06-07 04:02:22 -07:00
src/models/inventoryModels/inventoryModel.ts
@ -381,6 +381,7 @@ DuviriInfoSchema.set("toJSON", {
}
});
// eslint-disable-next-line @typescript-eslint/no-unused-vars
OrdisPrime (Migrated from github.com) commented 2024-06-07 04:01:54 -07:00
Copy Link

please undo removal of all genericItem2 instances. it has a purpose for later.

please undo removal of all genericItem2 instances. it has a purpose for later.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#277
No description provided.
Delete Branch "SpecialItems"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?