OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: implement startDojoRecipeController to place new rooms in Dojo #273

Merged
Sainan merged 6 commits from dojo-ii into main 2024-06-06 07:55:37 -07:00
Conversation 1 Commits 6 Files Changed 7 +77 -11
Sainan commented 2024-06-03 05:36:16 -07:00
Owner
Copy Link
No description provided.
OrdisPrime (Migrated from github.com) reviewed 2024-06-06 05:31:31 -07:00
src/controllers/api/startDojoRecipeController.ts
OrdisPrime (Migrated from github.com) commented 2024-06-06 05:27:58 -07:00
Author
Owner
Copy Link

could use getInventory()

could use getInventory()
OrdisPrime (Migrated from github.com) commented 2024-06-06 05:29:34 -07:00
Author
Owner
Copy Link

perhaps this could be a getGuild() function, seems like we would need that often

perhaps this could be a getGuild() function, seems like we would need that often
OrdisPrime (Migrated from github.com) commented 2024-06-06 05:30:11 -07:00
Author
Owner
Copy Link

i dont like the non-null assertion operator here.
I would prefer coding it such that it is checked before null before, so this is not needed

i dont like the non-null assertion operator here. I would prefer coding it such that it is checked before null before, so this is not needed
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#273
No description provided.
Delete Branch "dojo-ii"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?