OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 24 Pull Requests 2 Actions Packages Projects Releases Activity

fix: CrewShipFusion bug with SubroutineIndex #2714

Merged
Sainan merged 3 commits from AlexisinGit/SpaceNinjaServerAlexFork:main into main 2025-08-28 05:50:29 -07:00
Conversation 3 Commits 3 Files Changed 1 +1 -1
AlexisinGit commented 2025-08-27 16:42:52 -07:00
Contributor
Copy Link

Crewship fusion didn't agree with player's choice.

Expected results: image.png

What I actually get: image.png

export interface ICrewShipComponentFingerprint extends IInnateDamageFingerprint {
    SubroutineIndex?: number;
}

The interface already demand SubroutineIndex to exist, so it would be unnecessary to check.

Meanwhile, inferiorFingerprint.SubroutineIndex could be 0, 1, 2... and might be handled incorrectly as true/ false.

Crewship fusion didn't agree with player's choice. Expected results: ![image.png](/attachments/a61c96c7-1624-4dd4-9e4c-c6199d5af95a) What I actually get: ![image.png](/attachments/cf58aed4-18d9-4d97-8894-6c53762f366d) ``` export interface ICrewShipComponentFingerprint extends IInnateDamageFingerprint { SubroutineIndex?: number; } ``` The interface already demand SubroutineIndex to exist, so it would be unnecessary to check. Meanwhile, inferiorFingerprint.SubroutineIndex could be 0, 1, 2... and might be handled incorrectly as true/ false.
image.png
378 KiB
image.png
206 KiB
AlexisinGit added 1 commit 2025-08-27 16:42:53 -07:00
fix: CrewShipFusion bug with SubroutineIndex
All checks were successful
Build / build (pull_request) Successful in 1m46s
Details
62607f15ec
Sainan commented 2025-08-27 18:10:50 -07:00
Owner
Copy Link

I see there's a bug here, but I do think you should simply change the condition to inferiorFingerprint.SubroutineIndex !== undefined to avoid 0 being treated as false. I'm not sure outright removing it is a great idea.

I see there's a bug here, but I do think you should simply change the condition to `inferiorFingerprint.SubroutineIndex !== undefined` to avoid 0 being treated as false. I'm not sure outright removing it is a great idea.
AlexisinGit added 2 commits 2025-08-27 21:03:24 -07:00 
This reverts commit 62607f15ec76c6eda7e3a79c6a58c0c39547ec35.
fix: CrewShipFusion bug specify typecheck
All checks were successful
Build / build (pull_request) Successful in 1m23s
Details
8c8c651d63
AlexisinGit commented 2025-08-27 21:05:00 -07:00
Author
Contributor
Copy Link

It is done. A little type check won't do no harm.

It is done. A little type check won't do no harm.
Sainan approved these changes 2025-08-27 21:10:34 -07:00
Sainan merged commit a2171c80a5 into main 2025-08-28 05:50:29 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2714
No description provided.
Delete Branch "AlexisinGit/SpaceNinjaServerAlexFork:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?