Crashes and errors when same first part of email is used and second one (after @) is different (likely IGN conflict) #2528

New Issue

Animan8000 · 2025-07-21T07:07:34-07:00

Animan8000 commented

2025-07-21 07:07:34 -07:00

Example:

Create testshit@€ & testshit@e (in-game).
testshit@e might just error in-game (because the other account already exists).
testshit@€ however is also broken in WebUI too. If you try to login, WebUI will display a login failure (no error on console ever displayed I think)
Trying to register testshit@€ on WebUI causes SpaceNinjaServer to crash.

I assume its maybe related that both accounts technically would have the same IGN? Would maybe make sense, that one account is "testshit" and the next one becomes "testshit1" (if available) automatically as IGN or so. Logs:

Create (second) account:

2025-07-21T15:18:12:252 [0.1.0] error:  Error: error creating account E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } while processing /api/login.php request
    at loginController (D:\GitHub\spaceninjaserver\src\controllers\api\loginController.ts:61:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
2025-07-21T15:18:12:253 [0.1.0] http:   POST /api/login.php?buildLabel=2016.03.04.10.06/&clientMod=OpenWF%20Bootstrapper%20v0.11.7 500 14.569 ms - -
2025-07-21T15:18:15:057 [0.1.0] error:  Error: error creating account E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } while processing /api/login.php request
    at loginController (D:\GitHub\spaceninjaserver\src\controllers\api\loginController.ts:61:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
2025-07-21T15:18:15:057 [0.1.0] http:   POST /api/login.php?buildLabel=2016.03.04.10.06/&clientMod=OpenWF%20Bootstrapper%20v0.11.7 500 4.570 ms - -
2025-07-21T15:18:44:722 [0.1.0] error:  Error: error creating account E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } while processing /api/login.php request
    at loginController (D:\GitHub\spaceninjaserver\src\controllers\api\loginController.ts:61:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Trying to register testshit@€ in WebUI (while already existing in-game):

D:\GitHub\spaceninjaserver\src\services\loginService.ts:50
            throw new Error(error.message);
                  ^


Error: E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" }
    at createAccount (D:\GitHub\spaceninjaserver\src\services\loginService.ts:50:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async WebSocket.<anonymous> (D:\GitHub\spaceninjaserver\src\services\wsService.ts:106:27)

Node.js v23.8.0

Example: - Create `testshit@€` & `testshit@e` (in-game). - `testshit@e` might just error in-game (because the other account already exists). - `testshit@€` however is also broken in WebUI too. If you try to login, WebUI will display a login failure (no error on console ever displayed I think) - Trying to register `testshit@€` on WebUI causes SpaceNinjaServer to crash. I assume its maybe related that both accounts technically would have the same IGN? Would maybe make sense, that one account is "testshit" and the next one becomes "testshit1" (if available) automatically as IGN or so. Logs: Create (second) account: ``` 2025-07-21T15:18:12:252 [0.1.0] error: Error: error creating account E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } while processing /api/login.php request at loginController (D:\GitHub\spaceninjaserver\src\controllers\api\loginController.ts:61:23) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) 2025-07-21T15:18:12:253 [0.1.0] http: POST /api/login.php?buildLabel=2016.03.04.10.06/&clientMod=OpenWF%20Bootstrapper%20v0.11.7 500 14.569 ms - - 2025-07-21T15:18:15:057 [0.1.0] error: Error: error creating account E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } while processing /api/login.php request at loginController (D:\GitHub\spaceninjaserver\src\controllers\api\loginController.ts:61:23) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) 2025-07-21T15:18:15:057 [0.1.0] http: POST /api/login.php?buildLabel=2016.03.04.10.06/&clientMod=OpenWF%20Bootstrapper%20v0.11.7 500 4.570 ms - - 2025-07-21T15:18:44:722 [0.1.0] error: Error: error creating account E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } while processing /api/login.php request at loginController (D:\GitHub\spaceninjaserver\src\controllers\api\loginController.ts:61:23) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) ``` Trying to register `testshit@€` in WebUI (while already existing in-game): ``` D:\GitHub\spaceninjaserver\src\services\loginService.ts:50 throw new Error(error.message); ^ Error: E11000 duplicate key error collection: openWF.accounts index: DisplayName_1 dup key: { DisplayName: "testshit" } at createAccount (D:\GitHub\spaceninjaserver\src\services\loginService.ts:50:19) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async WebSocket.<anonymous> (D:\GitHub\spaceninjaserver\src\services\wsService.ts:106:27) Node.js v23.8.0 ```

~~Sainan referenced this issue 2025-07-21 07:40:48 -07:00~~

fix: add try/catch around websocket message event handler #2529

Sainan referenced this issue

2025-07-21 07:41:45 -07:00

fix: add try/catch around websocket message event handler #2529

Sainan added the

bug

label 2025-07-21 07:41:52 -07:00

Sainan referenced this issue from a commit

2025-07-21 07:44:56 -07:00

fix: add try/catch around websocket message event handler (#2529)

Sainan referenced a pull request that will close this issue