OpenWF/SpaceNinjaServer
22
24
Fork 25
Code Issues 20 Pull Requests 2 Actions Packages Projects Releases Activity

handle web ui riven parse error #2468

Closed
nyaoouo wants to merge 1 commits from nyaoouo:HandleWebUiRivenParseError into main
pull from: nyaoouo:HandleWebUiRivenParseError
merge into: OpenWF:main
Conversation 3 Commits 1 Files Changed 1 +6 -1
nyaoouo commented 2025-07-10 23:39:12 -07:00
Contributor
Copy Link

if invalid fingerprint is passed into parser, whole widget cant show
display fallback content to handle error (and allow user to remove invalid mod from web ui)

if invalid fingerprint is passed into parser, whole widget cant show display fallback content to handle error (and allow user to remove invalid mod from web ui)
nyaoouo added 1 commit 2025-07-10 23:39:12 -07:00
handle riven parse error
Some checks failed
Build / build (pull_request) Failing after 51s
Details
5865bdc057
Sainan commented 2025-07-11 00:13:50 -07:00
Owner
Copy Link

How do you even manage to get an invalid fingerprint here?

How do you even manage to get an invalid fingerprint here?
nyaoouo commented 2025-07-11 00:21:00 -07:00
Author
Contributor
Copy Link

How do you even manage to get an invalid fingerprint here?

The most simple case is that the webui allows users to freely enter fingerprints, so invalid fingerprints exist in save.

> How do you even manage to get an invalid fingerprint here? The most simple case is that the webui allows users to freely enter fingerprints, so invalid fingerprints exist in save.
nyaoouo commented 2025-07-11 00:24:22 -07:00
Author
Contributor
Copy Link

Or some "complex" case for example edit client to support upgrades not hardcode in RavenParser and cause loooooots of Uncaught TypeError: Cannot read properties of undefined in RavenParser.js

Or some "complex" case for example edit client to support upgrades not hardcode in RavenParser and cause loooooots of `Uncaught TypeError: Cannot read properties of undefined` in RavenParser.js
nyaoouo closed this pull request 2025-07-11 00:56:06 -07:00
Sainan deleted branch HandleWebUiRivenParseError 2025-07-11 02:55:09 -07:00
Some checks failed
Build / build (pull_request) Failing after 51s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2468
No description provided.
Delete Branch "nyaoouo:HandleWebUiRivenParseError"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?