OpenWF/SpaceNinjaServer
21
23
Fork 24
Code Issues 24 Pull Requests 4 Actions Packages Projects Releases Activity

chore: optimise creditsController #2359

Merged
Sainan merged 1 commits from faster-credits into main 2025-06-30 11:05:51 -07:00
Conversation 0 Commits 1 Files Changed 1 +9 -3
Sainan commented 2025-06-30 01:34:34 -07:00
Owner
Copy Link

Doing both lookups in parallel saves around 1 ms in the happy case (20% of baseline time), and in case nonce does not match, the error is simply raised as per usual with the inventory request being lightweight enough to be negligible.

Noteworthy that this reasoning doesn't really work for other controllers because in the error case, the inventory request would still be quite significant, even if the HTTP request itself would still finish quickly.

Doing both lookups in parallel saves around 1 ms in the happy case (20% of baseline time), and in case nonce does not match, the error is simply raised as per usual with the inventory request being lightweight enough to be negligible. Noteworthy that this reasoning doesn't really work for other controllers because in the error case, the inventory request would still be quite significant, even if the HTTP request itself would still finish quickly.
Sainan added 1 commit 2025-06-30 01:34:35 -07:00
chore: optimise creditsController
All checks were successful
Build / build (pull_request) Successful in 59s
Details
8683d4e85d 
Doing both lookups in parallel saves around 1 ms in the happy case (20% of baseline time), and in case nonce does not match, the error is simply raised as per usual with the inventory request being lightweight enough to be negligible.

Noteworthy that this reasoning doesn't really work for other controllers because in the error case, the inventory request would still be quite significant, even if the HTTP request itself would still finish quickly.
Sainan merged commit 0c9b27a29b into main 2025-06-30 11:05:51 -07:00
Sainan deleted branch faster-credits 2025-06-30 11:05:54 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2359
No description provided.
Delete Branch "faster-credits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?