OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 45 Pull Requests Actions Packages Projects Releases Activity

Add XP for SpaceSuits #233

Merged
0kolya0 merged 1 commits from main into main 2024-05-28 04:59:20 -07:00
Conversation 4 Commits 1 Files Changed 1 +7 -1
0kolya0 commented 2024-05-24 08:18:49 -07:00 (Migrated from github.com)
Copy Link

You forgot to add this...

You forgot to add this...
OrdisPrime commented 2024-05-28 04:31:41 -07:00 (Migrated from github.com)
Copy Link

will look at it later, cause there are some complications: My plan is to make a hierarchy of item types, also, there is GenericItem2 or so, which has those things you added in.

will look at it later, cause there are some complications: My plan is to make a hierarchy of item types, also, there is GenericItem2 or so, which has those things you added in.
0kolya0 commented 2024-05-28 04:37:42 -07:00 (Migrated from github.com)
Copy Link

then what stops you from adding it now so it works and then changing it when you find something better?

then what stops you from adding it now so it works and then changing it when you find something better?
Sainan commented 2024-05-28 04:41:34 -07:00
Copy Link

I agree the way items are handled in SpaceNinjaServer right now is horrible (Warframe, Weapon, GenericItem, GenericItem2, whatever else). We will probably have to converge on just a single GenericItem and settling on fields like ArchonCrystalUpgrades just being optional even if it only makes sense on a warframe.

Anyway, the current way "works". I'd say merge this PR to fix the immediate issues, and we can fix the larger issues later.

I agree the way items are handled in SpaceNinjaServer right now is horrible (Warframe, Weapon, GenericItem, GenericItem2, whatever else). We will probably have to converge on just a single GenericItem and settling on fields like ArchonCrystalUpgrades just being optional even if it only makes sense on a warframe. Anyway, the current way "works". I'd say merge this PR to fix the immediate issues, and we can fix the larger issues later.
0kolya0 commented 2024-05-28 04:49:55 -07:00 (Migrated from github.com)
Copy Link

I literally didn't want to make this change because I realized that the 7 lines of code you forgot to add would require "detailed review".Sorry, I didn’t mean to write in this style, I just don’t like this approach to update.

I literally didn't want to make this change because I realized that the 7 lines of code you forgot to add would require "detailed review".Sorry, I didn’t mean to write in this style, I just don’t like this approach to update.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#233
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?